-
Notifications
You must be signed in to change notification settings - Fork 64
feat(amazonq): inline unit test generation #1406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5/21 |
server/aws-lsp-codewhisperer/src/shared/supplementalContextUtil/unitTestIntentDetection.ts
Outdated
Show resolved
Hide resolved
server/aws-lsp-codewhisperer/src/shared/supplementalContextUtil/unitTestIntentDetection.ts
Outdated
Show resolved
Hide resolved
server/aws-lsp-codewhisperer/src/shared/supplementalContextUtil/unitTestIntentDetection.test.ts
Outdated
Show resolved
Hide resolved
@@ -1,7 +1,7 @@ | |||
// Port of implementation in AWS Toolkit for VSCode | |||
// https://github.com/aws/aws-toolkit-vscode/blob/9d8ddbd85f4533e539a58e76f7c46883d8e50a79/packages/core/src/codewhisperer/models/model.ts | |||
|
|||
export type UtgStrategy = 'ByName' | 'ByContent' | |||
export type UtgStrategy = 'ByName' | 'ByContent' | 'NEW_UTG' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should just call it UTG
|
server/aws-lsp-codewhisperer/src/shared/supplementalContextUtil/focalFileResolution.ts
Outdated
Show resolved
Hide resolved
server/aws-lsp-codewhisperer/src/shared/supplementalContextUtil/focalFileResolution.test.ts
Outdated
Show resolved
Hide resolved
server/aws-lsp-codewhisperer/src/shared/supplementalContextUtil/focalFileResolution.ts
Outdated
Show resolved
Hide resolved
server/aws-lsp-codewhisperer/src/shared/supplementalContextUtil/focalFileResolution.ts
Outdated
Show resolved
Hide resolved
server/aws-lsp-codewhisperer/src/shared/supplementalContextUtil/unitTestIntentDetection.ts
Outdated
Show resolved
Hide resolved
server/aws-lsp-codewhisperer/src/shared/supplementalContextUtil/unitTestIntentDetection.ts
Show resolved
Hide resolved
supplementalContextValue = await waitUntil( | ||
async function () { | ||
const focalFile = await utgFocalFileResolver.inferFocalFile(document, workspace) | ||
if (focalFile) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When isUtg
is true but inferFocalFile
fails to identify a focal file, should we fall back to using BM25 to retrieve supplemental context? Currently, the logic seems to return an empty result in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will follow up
Problem
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.