feat(q): builderid "paid tier" flow #1197
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
changed the title
justinmk3
commented
Apr 29, 2025
| return response | ||
| throw e | ||
| } finally { | ||
| this.inflightRequests.delete(controller) |
There was a problem hiding this comment.
This was a potential bug? If the service returns an error (which throws), the inflightRequests would not get updated.
There was a problem hiding this comment.
good catch, indeed I think we were not handling service errors. Thanks for working on the fix.
justinmk3
force-pushed
the
paidtier
branch
4 times, most recently
from
cab289b to
939e748
Compare
justinmk3
force-pushed
the
paidtier
branch
11 times, most recently
from
ef043b3 to
1968d12
Compare
justinmk3
force-pushed
the
paidtier
branch
7 times, most recently
from
b40cd74 to
027e119
Compare
1. get latest service models:
- `client/token/bearer-token-service.json`
- from: `<AWSVectorConsolasRuntimeServiceModel>/aws-sdk-external-2022-11-11/c2j/codewhispererruntime-2022-11-11.json`
- `client/sigv4/service.json`
- from: `<AWSVectorConsolasRuntimeServiceModel>/aws-sdk-external/c2j/codewhisperer-2024-10-25.json`
2. !!NOTE!! remove line `"signatureVersion": "bearer",` from `bearer-token-service.json`
3. restore the script that was mysteriously reverted in
aws#161 without any
documented alternative...
4. run `./node_modules/.bin/ts-node server/aws-lsp-codewhisperer/script/genclient.ts`
service model version: 1.0.20901.0
- control MynahUI from Flare server
justinmk3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When "free tier" limit is reached, there are no clear next steps.
Solution
Handle "free tier exceeded" throttling/quota service error.
Todo
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.