Skip to content

feat: implement automatic bidirectional environment variable synchronization #4876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: implement automatic bidirectional environment variable synchronization #4876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01cc437
feat: implement automatic bidirectional environment variable synchron…
tinovyatkin Jul 31, 2025
1264712
refactor: improve type safety with Literal types for environment changes
tinovyatkin Jul 31, 2025
b3c4a3a
chore: update snapshot
tinovyatkin Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
432 changes: 432 additions & 0 deletions packages/@jsii/kernel/src/api-environment.test.ts
View file
Open in desktop

Large diffs are not rendered by default.

23 changes: 21 additions & 2 deletions packages/@jsii/kernel/src/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,12 @@ export interface Callback {
readonly invoke?: InvokeRequest;
readonly get?: GetRequest;
readonly set?: SetRequest;
readonly envChange?: {
readonly type: 'set' | 'delete';
readonly key: string;
readonly value?: string;
readonly oldValue?: string;
};
}

export interface HelloResponse {
Expand Down Expand Up @@ -256,6 +262,17 @@ export interface StatsResponse {
readonly objectCount: number;
}

export interface EnvironmentChangeRequest {
readonly api: 'env.notifyChange';
readonly key: string;
readonly value?: string;
readonly type: 'set' | 'delete';
}

export interface EnvironmentChangeResponse {
readonly success: boolean;
}

export type KernelRequest =
| LoadRequest
| CreateRequest
Expand All @@ -268,7 +285,8 @@ export type KernelRequest =
| CallbacksRequest
| CompleteRequest
| NamingRequest
| StatsRequest;
| StatsRequest
| EnvironmentChangeRequest;

export type KernelResponse =
| HelloResponse
Expand All @@ -283,7 +301,8 @@ export type KernelResponse =
| CallbacksResponse
| CompleteResponse
| NamingResponse
| StatsResponse;
| StatsResponse
| EnvironmentChangeResponse;

export interface OkayResponse {
readonly ok: any;
Expand Down
Loading
Loading