Skip to content

Helm chart variable to specify webhook annotations #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Helm chart variable to specify webhook annotations #1106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb907d4
Add webhook annotations
ankursgupta87 May 18, 2024
25aa432
Add webhook annotations
ankursgupta87 May 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions stable/aws-load-balancer-controller/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ The default values set by the application itself can be confirmed [here](https:/
| `webhookTLS.cert` | TLS certificate for webhook (auto-generated if not provided) | "" |
| `webhookTLS.key` | TLS private key for webhook (auto-generated if not provided) | "" |
| `webhookNamespaceSelectors` | Namespace selectors for the wekbook | None |
| `webhookAnnotations` | Annotations to be added to webhook configurations resource | `{}` |
| `keepTLSSecret` | Reuse existing TLS Secret during chart upgrade | `true` |
| `serviceAnnotations` | Annotations to be added to the provisioned webhook service resource | `{}` |
| `serviceMaxConcurrentReconciles` | Maximum number of concurrently running reconcile loops for service | None |
Expand Down
14 changes: 12 additions & 2 deletions stable/aws-load-balancer-controller/templates/webhook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,14 @@
apiVersion: admissionregistration.k8s.io/v1
kind: MutatingWebhookConfiguration
metadata:
{{- if $.Values.enableCertManager }}
{{- if or $.Values.enableCertManager $.Values.webhookAnnotations }}
annotations:
{{- if $.Values.webhookAnnotations }}
{{- toYaml $.Values.webhookAnnotations | nindent 4}}
{{- end }}
{{- if $.Values.enableCertManager }}
cert-manager.io/inject-ca-from: {{ .Release.Namespace }}/{{ template "aws-load-balancer-controller.namePrefix" . }}-serving-cert
{{- end }}
{{- end }}
name: {{ include "aws-load-balancer-controller.namePrefix" . }}-webhook
labels:
Expand Down Expand Up @@ -121,9 +126,14 @@ webhooks:
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
{{- if $.Values.enableCertManager }}
{{- if or $.Values.enableCertManager $.Values.webhookAnnotations }}
annotations:
{{- if $.Values.webhookAnnotations }}
{{- toYaml $.Values.webhookAnnotations | nindent 4}}
{{- end }}
{{- if $.Values.enableCertManager }}
cert-manager.io/inject-ca-from: {{ .Release.Namespace }}/{{ template "aws-load-balancer-controller.namePrefix" . }}-serving-cert
{{- end }}
{{- end }}
name: {{ include "aws-load-balancer-controller.namePrefix" . }}-webhook
labels:
Expand Down
3 changes: 3 additions & 0 deletions stable/aws-load-balancer-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ updateStrategy: {}
# maxSurge: 1
# maxUnavailable: 1

# webhookAnnotations contains annotations to be added to webhooks.
webhookAnnotations: {}

# serviceAnnotations contains annotations to be added to the provisioned webhook service resource
serviceAnnotations: {}

Expand Down