fix(getting-started-python): remove spaces from pyenv arguement #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very helpful for speeding testing up.
The former line would fail (at least in my shell) as two spaces would be prefixed with the version. I think bash will happily discard the spaces if it is not saved as a variable... otherwise it keeps them as the value. Also added 3.9.0 for [py39](https://github.com/aws/aws-encryption-sdk-python/blob/2e3ca4c5eb6843e0cf550e5a67f77ccb1e561dc3/tox.ini#L3)
texastony
commented
Aug 6, 2021
Co-authored-by: Ben Farley <[email protected]>
Co-authored-by: Ben Farley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
• Described passing multiple environments to
toxto be run in parallel, which has been very helpful to me.• Fixed bug in
pyenvinstallation script.• Explicitly added 3.9.0 for Python 3.9. The script would fetch 3.9-dev if it was fetched the other way.
Testing:
Tested script locally.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.