-
Notifications
You must be signed in to change notification settings - Fork 688
fix(amazonq): auto save the current file when users trigger auto debug commands #7883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
@@ -97,6 +97,7 @@ export class AutoDebugCommands implements vscode.Disposable { | |||
if (!editor) { | |||
return | |||
} | |||
await editor.document.save() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please throw when this save function returns false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
6b9ee53
to
ff57b73
Compare
8804971
to
6921ef7
Compare
Problem
Amazon Q couldn't make changes to unsaved files. When users apply fix commands to unsaved files, Amazon Q couldn't fix those problems.
Solution
Auto save the file when users clicking on the fix commands.
feature/x
branches will not be squash-merged at release time.