feat(amazonq): show code diff instead of only code fix for fix preview #6742
+12
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ctlai95
reviewed
Mar 7, 2025
ctlai95
reviewed
Mar 7, 2025
packages/amazonq/.changes/next-release/Bug Fix-a7de0f94-cd21-4adc-8fcf-3082aa862528.json
Outdated
Show resolved
Hide resolved
ctlai95
reviewed
Mar 7, 2025
| \`\`\` | ||
| `) | ||
| const parser = new DOMParser() | ||
| const doc = parser.parseFromString(htmlString, 'text/html') | ||
| const referenceTracker = doc.querySelector('.reference-tracker') |
There was a problem hiding this comment.
I think we will need this soon, but it probably won't work with the diff view.
There was a problem hiding this comment.
Yes we can add it back once it is needed.
ctlai95
approved these changes
Mar 8, 2025
ctlai95
changed the title
hayemaxi
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We currently see only code fix for fix preview. We want to see the diff containing both code fix and original code.
Solution
Remove logic to generate only the code fix.
Remove logic for line number as it will be different for the diff.
/review: show code diff instead of only code fix for fix preview
feature/xbranches will not be squash-merged at release time.