telemetry: computeEnv reports "wsl" for all remote envs #6735
+17
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
duplicate code appears unrelated. (addressed in #6737) |
Hweinstock
approved these changes
Mar 6, 2025
tomcat323
approved these changes
Mar 6, 2025
| @@ -292,12 +298,16 @@ export async function getComputeEnvType(): Promise<EnvType> { | |||
| return 'ec2-amzn' | |||
| } | |||
| return 'ec2' | |||
| } else if (env.remoteName) { | |||
| } else if (env.remoteName === 'wsl') { | |||
| return 'wsl' | |||
| } else if (isAutomation()) { | |||
| return 'test' | |||
| } else if (!env.remoteName) { | |||
There was a problem hiding this comment.
env.remoteName is undefined in web mode, so I don't think this will hit the web if condition.
I think we may want to ensure the local condition is last, and then add a comment noting nothing should be added after it (Except the unknown case)
There was a problem hiding this comment.
thanks for mentioning that :) pushed a fix.
unknown cannot happen anymore, because the last 2 conditions check env.remoteName and !env.remoteName.
Problem: 1. `computeEnv` reports "wsl" for all remote envs. 2. `computeEnv` does not report "web" envs. Solution: 1. Only report "wsl" for WSL envs. 2. Report "remote" for other remote envs. 3. Report "web" for unknown web envs.
justinmk3
pushed a commit
that referenced
this pull request
Mar 10, 2025
nkomonen-amazon
approved these changes
Mar 11, 2025
chungjac
added a commit
to chungjac/aws-toolkit-vscode
that referenced
this pull request
Mar 11, 2025
fix endpoint refactor(cw): remove unused keep-alive workaround. (aws#6694) This code is no longer used, and appears to have been moved to the LSP side: aws/aws-toolkit-vscode-staging#1214 (comment) This fix also no longer works, and the work it was based off has significantly changed their approach: https://github.com/sourcegraph/cody/blob/62d73f78c432036d1f99bc9631ed534cc2ed846b/vscode/src/net/net.patch.ts - remove it. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. test(e2e): increase file watcher count to prevent ENOSPC errors test(amazonq): retry inline tests if no valid response was found Merge pull request aws#6757 from jpinkney-aws/stabilize-test test(amazonq): add retries to flaky e2e tests telemetry(amazonq): status field tracking user actions aws#6750 - The current unit test generation telemetry event lacks a field to distinguish between user actions: acceptance, rejection, failure, or cancellation. - Enhancing the amazonq_utgGenerateTests telemetry event by incorporating a status field to capture user actions in toolkit metrics. - Bumping telemetry version to `1.0.307` fix(amazonq): incorrect zip entry path for file scans aws#6741 Reproduce steps: 1. Open a window with multiple workspace folders, for example `workspaceFolders: [folder1, folder2]` 2. Open any file and run a code review on the active file, for example `folder1/sample.py` 3. The zip entry will be created with the workspaceFolder duplicated, for example `folder1/folder1/sample.py` Explicitly set `includeWorkspaceFolder` to false when getting the relative path of the file. fix(amazonq): keyboard navigation in "Create a new prompt" overlay aws#6738 When a user selects "Create a new prompt", a mouse is required to 1) select the prompt name input field and 2) click the Enter button. This flow should be able to be completed with just the keyboard Autofocus prompt input field, and allow submit on Enter key press. fix(amazonq): duplicates in lsp getContextCommandPrompt aws#6756 There are two types of context shown in the context list: 1. the ones by explicit @ 2. the ones by @workspace 1) has relativePaths with start/end line being -1, 2) has relativePaths with non -1 start/end lines, 1) is doing dedupe with 2) but 1) also needs to dedupe itself ci(jscpd): show hint message on detection of clones aws#6737 There appears to be cases where the fix pushed here fails: aws#6572. ex: aws#6735 - re-add the hint message for the case described here: aws#6564 feat(amazonq): feedback system for internal users for /test aws#6748 - The unit test generation team lacks sufficient feedback to enhance the quality of their produced tests. - Implementing the feedback system for internal users to evaluate and enhance unit test generation quality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
computeEnvreports "wsl" for all remote envs.computeEnvdoes not report "web" envs.Solution
feature/xbranches will not be squash-merged at release time.