fix(appbuilder): Prevent parallel build processes on the same template #6172
Conversation
mbfreder
changed the title
mbfreder
force-pushed
the
parallel-build
branch
2 times, most recently
from
654bf52 to
3471429
Compare
mbfreder
force-pushed
the
parallel-build
branch
from
3471429 to
86848f2
Compare
mbfreder
force-pushed
the
parallel-build
branch
from
c46878d to
0922083
Compare
- updated test with a small delay to avoid possible race condition and test flakiness
|
|
||
| export async function registerTemplateBuild(templatePath: string) { | ||
| const expirationDate = Date.now() + 5 * 60 * 1000 // five minutes | ||
| await updateRecentResponse(buildProcessMementoRootKey, globalIdentifier, templatePath, expirationDate.toString()) |
There was a problem hiding this comment.
What happens if a build takes longer than 5 minutes? Customer feedback shows that builds can be very, very slow. If the user Cancels the build is that correctly handled?
| } | ||
| } | ||
|
|
||
| export async function registerTemplateBuild(templatePath: string) { |
There was a problem hiding this comment.
"registering" is usually a sign of a design flaw. registries require lifecycle management, and can get "corrupted" by logic bugs (like any "cache" in general).
Is there instead a way we can check SAM CLI's state (e.g. in the .sam-... directory) to see if it's currently building something? Or a way to run sam ... and it will tell us if a build is in-progress? Calculating answers (querying) is much more reliable and robust than storing flags and cleaning up state.
There was a problem hiding this comment.
We currently can't check sam cli state in the toolkit. I think this is the best we can do right now, until we find a solution in SAM CLI.
mbfreder
force-pushed
the
parallel-build
branch
from
2595dbc to
ea77516
Compare
Context
We currently allow multiple build processes to run at the same time for the same template.
Problem
When running a build, it’s possible to start a second build for the same project. This results in both builds failings
Solution
Prevent parallel builds on the same template
feature/xbranches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.