Skip to content

Support bearer tokens through environment for Bedrock #3266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 21, 2025
Merged

Conversation

mullermp
Copy link
Contributor

@mullermp mullermp commented Jul 2, 2025

Supports bearer tokens through ENV only for Bedrock. Scoped to two clients for now (others are planned). Precedence of the bearer token will also enforce this auth scheme preference (not yet implemented). A metric is added when used.

Alternate approach is to put logic in TokenProviderChain to read from ENV (perhaps a future generalized approach can do this).

Copy link

github-actions bot commented Jul 2, 2025

You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md.

@aws aws deleted a comment from github-actions bot Jul 2, 2025
Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall - minor comments.

Copy link

github-actions bot commented Jul 2, 2025

Detected 3 possible performance regressions:

  • aws-sdk-sns.client_mem_allocated - z-score regression: 0.6 -> 0.6. Z-score: 17.73
  • aws-sdk-kinesis.client_mem_retained - z-score regression: 0.11 -> 0.11. Z-score: Infinity
  • aws-sdk-kinesis.client_mem_allocated - z-score regression: 0.63 -> 0.63. Z-score: Infinity

Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - LGTM

@mullermp mullermp merged commit da47b00 into version-3 Jul 21, 2025
28 checks passed
@mullermp mullermp deleted the bearer-env branch July 21, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants