Skip to content

Conversation

stobrien89
Copy link
Member

Description of changes:
Adds a provider to fetch token values from environment. If found, sets auth scheme preference to prefer bearer. Additional tests will be added once #3156 is approved and merged.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@yenfryherrerafeliz yenfryherrerafeliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some minor changes and some questions.

Thanks!

@stobrien89 stobrien89 force-pushed the feat-bedrock-token-provider branch from 1c651d3 to 5dd1dbb Compare August 14, 2025 22:56
Copy link
Contributor

@yenfryherrerafeliz yenfryherrerafeliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean implementation. Just a question and two minor asks.

Thanks!

@stobrien89 stobrien89 force-pushed the feat-bedrock-token-provider branch from 5dd1dbb to 6053a51 Compare August 15, 2025 22:53
@stobrien89
Copy link
Member Author

Smoke test run:

vendor/bin/behat --format=progress --suite=smoke --tags='~@noassumerole'
...................................................................... 70
...................................................................... 140
...................................................................... 210
............

111 scenarios (111 passed)
222 steps (222 passed)
0m30.58s (95.24Mb)

Integ test run:

vendor/bin/behat --format=progress --tags=integ
...................................................................... 70
...................................................................... 140
...................................................................... 210
......................................

66 scenarios (66 passed)
248 steps (248 passed)
8m4.51s (48.33Mb)

@stobrien89 stobrien89 merged commit 3c96192 into aws:master Aug 19, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants