Fix User-Agent duplication and support case-sensitive constant classes for feature IDs #3763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolved an issue where the User-Agent header would grow on each request when reusing the same request object, this was caused by reusing the same
UserAgentDetails
instance attached to the request.Fixed this by creating a copy of the request’s
UserAgentDetails
in theRequestContext
instead of reusing the request instance.Also found an issue where
ConstantClass
defaulted to case-insensitive comparisons, which caused conflicts with similarly named feature IDs.For example when copying
PAGINATOR ("C")
feature id from the request to theRequestContext
theFLEXIBLE_CHECKSUMS_RES_WHEN_REQUIRED ("c")
feature id gets added instead.Added
ConstantClassComparerAttribute
that allows derived ConstantClass types to specify the desired comparer type (OrdinalIgnoreCase, Ordinal.), and default behavior remainsOrdinalIgnoreCase
to preserve existing behavior.Updated the feature ID constant class to use
Ordinal
to support case-sensitive identifiers.Motivation and Context
#3759
Testing
DRY_RUN-20271a23-b168-4004-b640-ec5a77fb847b
Screenshots (if appropriate)
Types of changes
Checklist
License