Removed customization in ec2.customizations.json which excluded DryRun property from service request model and marked AmazonEC2Client.DryRun() extension method as obsolete. #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishdhingra
force-pushed
the
user/ashdhin/v4-ec2-DryRun-Inclusion
branch
from
47f6437 to
675307c
Compare
normj
reviewed
Feb 24, 2025
| "serviceName": "EC2", | ||
| "type": "patch", | ||
| "changeLogMessages": [ | ||
| "Removed customization in ec2.customizations.json which excluded DryRun property from service request model and marked AmazonEC2Client.DryRun() extension method as obsolete." |
There was a problem hiding this comment.
The change log should be focused on the customer and they won't understanding anything about removing the customization file. Here is my suggestion.
[Breaking Change] Removed DryRun method from service client. To perform a dry run use the DryRun property on the request object for individual EC2 operations.
There was a problem hiding this comment.
Thanks for the review. Updated change log message.
dscpinheiro
approved these changes
Feb 24, 2025
ashishdhingra
force-pushed
the
user/ashdhin/v4-ec2-DryRun-Inclusion
branch
from
675307c to
b877e67
Compare
normj
reviewed
Feb 24, 2025
| "serviceName": "EC2", | ||
| "type": "patch", | ||
| "changeLogMessages": [ | ||
| "[Breaking Change] Removed DryRun method from service client. To perform a dry run use the DryRun property on the request object for individual EC2 operations." |
There was a problem hiding this comment.
My mistake in the previous comment. This should say obsoleted not removed.
[Breaking Change] Obsoleted DryRun method from service client. To perform a dry run use the DryRun property on the request object for individual EC2 operations.
…n property from service request model and marked AmazonEC2Client.DryRun() extension method as obsolete.
ashishdhingra
force-pushed
the
user/ashdhin/v4-ec2-DryRun-Inclusion
branch
from
b877e67 to
932bbef
Compare
normj
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed customization in ec2.customizations.json which excluded
DryRunproperty from service request model and markedAmazonEC2Client.DryRun()extension method as obsolete.Motivation and Context
Follow up action item for #3595 in V4.
NOTE:
DryRunproperty astruewhen usingDescribeImagesAPI operation.DryRunproperty is error response, which isDryRunOperationif there are necessary permissions, otherwise, it isUnauthorizedOperation.Testing
Dry-run
DRY_RUN-0c782e9e-d350-47d3-91bf-bce3093fc969completed successfully.Screenshots (if appropriate)
Types of changes
Checklist
License