Skip to content

Conversation

heecheolman
Copy link

@heecheolman heecheolman commented Aug 14, 2024

Issue

  • x

Description

If the @aws-sdk/client-sts package is intended to be a singleton, it should be added to the peerDependencies of @aws-sdk/credential-provider-node.

Otherwise, in a Yarn Berry environment, you may encounter the following error:

@aws-sdk/credential-provider-node@npm:3.629.0 doesn't provide @aws-sdk/client-sts, requested by @aws-sdk/credential-provider-web-identity
  • @aws-sdk/client-s3@latest has a dependency on @aws-sdk/credential-provider-node (code)
  • @aws-sdk/credential-provider-node@latest has a dependency on @aws-sdk/credential-provider-web-identity (code)
  • @aws-sdk/credential-provider-web-identity@latest lists @aws-sdk/client-sts as a peerDependency (code)

Testing

Before:

  • Installing @aws-sdk/client-s3 in a Yarn Berry environment results in the above error.

After:

  • Installing @aws-sdk/client-s3 in a Yarn Berry environment no longer triggers the error.

Additional context

x

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@heecheolman heecheolman requested a review from a team as a code owner August 14, 2024 15:10
@heecheolman
Copy link
Author

review please

@kuhe
Copy link
Contributor

kuhe commented Jun 17, 2025

Thank you for your contribution. After evaluating alternative options this is no longer needed since the various credential provider packages now used a separate STS client and have declared a direct dependency on it.

The root error has been fixed by the change.

@kuhe kuhe closed this Jun 17, 2025
Copy link

github-actions bot commented Jul 2, 2025

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants