Fix PutObject with CRT client chunkedEncodingEnabled(false)#7129
Merged
davidh44 merged 8 commits intoJul 13, 2026
Conversation
Contributor
|
Can we scope this PR to just the root cause: the fix in The other changes (FlexibleChecksummer ordering, contentLength propagation, the Content-Length/Transfer-Encoding fix in MakeAsyncHttpRequestStage) are independent fixes. Can we raise them as separate PRs so each is easy to review, test, and bisect if anything regresses? |
joviegas
approved these changes
Jul 13, 2026
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
S3
PutObjecthangs indefinitely when usingAwsCrtAsyncHttpClientwithchunkedEncodingEnabled(false). Bug introduced in2.30.0whenrequestChecksumCalculationdefaulted toWHEN_SUPPORTED, which triggers automatic checksum computation forPutObject. With chunked encoding disabled, the SDK buffers the payload intoInMemoryPublisherto compute a header-based checksum. CRT's subscriber callsrequest(1)synchronously from withinonNext()(legal per Reactive Streams spec), causing a re-entrant deadlock inInMemoryPublisher.fulfillDemand().Modifications
InMemoryPublisher.fulfillDemand()— Fix re-entrant deadlock: return immediately on re-entrant call instead of spinning; outerdo-whilere-checks demand after releasing for multi-threaded safety.InMemoryPublisher.request()— Validaten > 0per Reactive Streams spec §3.9.Testing
Added unit, integration, and TCK tests
Types of changes
License