Skip to content

bugfix: set expiration time for container credential provider #6481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −0
Open

bugfix: set expiration time for container credential provider #6481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0a2382
bugfix: set expiration time for container credential provider
RyanTheKodiak Oct 15, 2025
8ac8724
Merge branch 'master' into bugfix/set-container-credentials-provider-…
carhaz Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/next-release/bugfix-AWSSDKforJavav2-6cad045.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"type": "bugfix",
"category": "AWS SDK for Java v2",
"contributor": "carhaz",
"description": "Update session credentials builder in HttpsCredentialsLoader to include expiration time so it's set in session credentials for ContainerCredentialsProvider"
}
1 change: 1 addition & 0 deletions ...src/main/java/software/amazon/awssdk/auth/credentials/internal/HttpCredentialsLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ public AwsCredentials getAwsCredentials() {
.accessKeyId(accessKeyId)
.secretAccessKey(secretKey)
.sessionToken(token)
.expirationTime(expiration)
.providerName(providerName)
.build() :
AwsBasicCredentials.builder()
Expand Down
5 changes: 5 additions & 0 deletions ...c/test/java/software/amazon/awssdk/auth/credentials/ContainerCredentialsProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
import software.amazon.awssdk.core.util.SdkUserAgent;
import software.amazon.awssdk.testutils.EnvironmentVariableHelper;

import java.util.Optional;

/**
* Tests for the {@link ContainerCredentialsProviderTest}.
*/
Expand All @@ -47,6 +49,7 @@ public class ContainerCredentialsProviderTest {
private static final String ACCESS_KEY_ID = "ACCESS_KEY_ID";
private static final String SECRET_ACCESS_KEY = "SECRET_ACCESS_KEY";
private static final String TOKEN = "TOKEN_TOKEN_TOKEN";
private static final String EXPIRATION_TIME = "3000-05-03T04:55:54Z";
private ContainerCredentialsProvider credentialsProvider;
private static EnvironmentVariableHelper helper = new EnvironmentVariableHelper();

Expand Down Expand Up @@ -92,6 +95,8 @@ public void testGetCredentialsReturnsValidResponseFromEcsEndpoint() {
assertThat(credentials.accessKeyId()).isEqualTo(ACCESS_KEY_ID);
assertThat(credentials.secretAccessKey()).isEqualTo(SECRET_ACCESS_KEY);
assertThat(credentials.sessionToken()).isEqualTo(TOKEN);
assertThat(credentials.expirationTime().isPresent());
assertThat(credentials.expirationTime().get()).isEqualTo(EXPIRATION_TIME);
assertThat(credentials.providerName()).isPresent().contains(BusinessMetricFeatureId.CREDENTIALS_HTTP.value());
}

Expand Down