Add PresignedUrlManager support to sync S3 client codegen #6249
+3,088
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zoewangg
reviewed
Jul 11, 2025
| @@ -232,4 +232,20 @@ protected MethodSpec serviceClientConfigMethod() { | |||
| .addStatement("return delegate.serviceClientConfiguration()") | |||
| .build(); | |||
| } | |||
|
|
|||
| @Override | |||
| protected void addPresignedUrlManagerMethod(TypeSpec.Builder type) { | |||
There was a problem hiding this comment.
I thought we are only going to generate this in async client, is that not the case?
There was a problem hiding this comment.
The delegating client needs the presignedUrlManager implementation because DelegatingS3Client implements the S3Client interface - without it, we get a compilation error "CLASS DelegatingS3Client.presignedUrlManager cannot be default" since interface methods can't be default methods in this case, so we need to maintain the delegation pattern by forwarding the call to the delegate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
PresignedUrlManageris a new API that users need to access through the S3 client. This PR extends the codegen framework to generatePresignedUrlManagersupport for S3 clients.Modifications
Added
presignedUrlManagerSupportedflag toCustomizationConfig.Extended codegen to generate presignedUrlManager() method in sync client interfaces and implementations.
Testing
Added codegen unit tests for pre-signed URL manager generation.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License