Skip to content

Handled commed for merge to master PR 6220 #6240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 8, 2025

Conversation

joviegas
Copy link
Contributor

@joviegas joviegas commented Jul 8, 2025

Motivation and Context

Modifications

License

  • I confirm that this pull request can be released under the Apache 2 license

@joviegas joviegas requested a review from a team as a code owner July 8, 2025 00:57
@joviegas joviegas force-pushed the joviegas/post-surface-api-review branch from c9c6123 to 3a51be0 Compare July 8, 2025 01:15
Copy link

sonarqubecloud bot commented Jul 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
63.2% Coverage on New Code (required ≥ 80%)
19.2% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)
B Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Contributor

@Fred1155 Fred1155 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, there are several comments in PR 6220 that are not addressed. Will that be in follow-up PR?

@joviegas joviegas merged commit 251490c into feature/master/apache5x Jul 8, 2025
26 of 27 checks passed
Copy link

github-actions bot commented Jul 8, 2025

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants