-
Notifications
You must be signed in to change notification settings - Fork 912
Bump OpenRewrite to 3.6.1 #6072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
v2-migration/src/test/java/software/amazon/awssdk/v2migration/ChangeConfigTypesTest.java
Outdated
Show resolved
Hide resolved
v2-migration/src/test/java/software/amazon/awssdk/v2migration/ChangeConfigTypesTest.java
Show resolved
Hide resolved
|
Hi @jhult , can I ask your motivation/use-case for the version bump in the SDK? The tool can be used standalone specifying the version the SDK supports, i.e.,
Reason for delay is we are facing difficulties with importing the newer versions of OpenRewrite dependencies internally. We hope to resolve and merge eventually but its not a priority for us at the moment. |
Motivation and Context
Continuation of #6040 to bump
rewrite-recipe-bom
to3.6.1
(OpenRewrite v8.50.2)Cannot bump to to latest
3.7.0
asJavaType.Method
constructors were dropped, requires further refactoring in SDK recipesModifications
ChangeMethodInvocationReturnType
and use OpenRewrite oneL
to content length arg inRequestBody.fromInputStream()
as it is not necessary and breaks with the version bumprewrite-maven-plugin
6.6.0
rewrite-gradle-plugin
7.4.1
Testing
Ran end to end tests