Improve update-reproducibles workflow: auto-push for internal PRs, verify for forks#8714
Open
roger-zhangg wants to merge 3 commits intoaws:developfrom
Open
Improve update-reproducibles workflow: auto-push for internal PRs, verify for forks#8714roger-zhangg wants to merge 3 commits intoaws:developfrom
roger-zhangg wants to merge 3 commits intoaws:developfrom
Conversation
reedham-aws
previously approved these changes
Feb 27, 2026
Member
Author
|
looks like this if external PR need update reproducible Before this action will fail directly on external prs when it got triggered |
Vandita2020
reviewed
Feb 27, 2026
| run: make update-reproducible-reqs-uv | ||
| - name: Fail if requirements are out of date | ||
| run: | | ||
| if ! git diff --quiet requirements/reproducible-*.txt; then |
Contributor
There was a problem hiding this comment.
Correct me if I'm wrong here. This check here is basically just asking contributors to run make update-reproducible-reqs-uv if they are making any changes to requirements file and otherwise too, right?
Member
Author
There was a problem hiding this comment.
Yes that's the idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes