chore(runtime): move ruby3.3 out of test runtime #7849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruby 3.3 is officially supported
github-actions
bot
added
area/local/start-api
roger-zhangg
removed
the
stage/needs-triage
valerena
reviewed
Jan 25, 2025
samcli/local/docker/lambda_image.py
Outdated
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| RAPID_IMAGE_TAG_PREFIX = "rapid" | |||
|
|
|||
| TEST_RUNTIMES = ["ruby3.3"] | |||
| TEST_RUNTIMES = ["N/A"] | |||
There was a problem hiding this comment.
I see that you tried to do TEST_RUNTIMES = [] first (which seems like the most logical option) but it failed to build.
However, the failure in the build is
samcli/local/docker/lambda_image.py:34: error: Need type annotation for "TEST_RUNTIMES" (hint: "TEST_RUNTIMES: list[<type>] = ...") [var-annotated]
So I feel it would be better to actually leave it empty and with that type annotation, which I think it should be something like this:
TEST_RUNTIMES: list[str] = []
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby 3.3 is officially supported
Which issue(s) does this change fix?
#7839
Why is this change necessary?
The latest public.ecr.aws/lambda/ruby:3.3 is upgraded to 3.3.5 but sam local invoke still uses public.ecr.aws/lambda/ruby:3.3-preview and the version is 3.3.0 this version has some bug cause sam local invoke cannot work correctly.
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.