-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support AWS::Lambda::Alias type resolving #7833
Conversation
Hi @rangerthegood Thanks for sending the PR! I was trying to reproduce the issue you mentioned in the issue to better understand and review the PR. However the project I got from |
Steps to reproduce: Setup patched sam install:
Setup POC CDK repo:
Output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the sample project. LGTM!
Which issue(s) does this change fix?
#7832
Why is this change necessary?
Without this change it is not possible to use
start-api
when your SpecRestApi is wired up with a Lambda function Alias versus just a Lambda, which would work fine.How does it address the issue?
The code change introduces a new type resolvers for
AWS::Lambda:Alias
, This resolver works by looking at theFunctionName
property. Once it has access to the function name it uses the existingarn_resolver
function to retrieve the result.What side effects does this change have?
None, that I'm aware of, I've introduced an additional test case to demonstrate the feature, and the existing test cases all still pass.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.