[Test] Quarantine AD stacks on failure for debugging purposes. #6742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarciani
added
skip-changelog-update
gmarciani
force-pushed
the
wip/mgiacomo/3130/wip/mgiacomo/3130/fix-ad-0317-1
branch
3 times, most recently
from
0dc1070 to
f41efd2
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gmarciani
force-pushed
the
wip/mgiacomo/3130/wip/mgiacomo/3130/fix-ad-0317-1
branch
2 times, most recently
from
ab22bf3 to
3051466
Compare
| @@ -28,6 +28,7 @@ | |||
| from jinja2.sandbox import SandboxedEnvironment | |||
| from retrying import retry | |||
| from time_utils import minutes, seconds | |||
| from constants import QUARANTINE_TAG_KEY, DO_NOT_DELETE_TAG_KEY, QUARANTINE_TAGS | |||
Check notice
Code scanning / CodeQL
Unused import Note test
gmarciani
force-pushed
the
wip/mgiacomo/3130/wip/mgiacomo/3130/fix-ad-0317-1
branch
3 times, most recently
from
63a7e22 to
a088a2e
Compare
In particular: 1. Make the Ad admin node signal the failure, not only the success; in this way the wait condition handle can fail faster. 2. reduced the number of retries made by adcli from 5 to 3 because in case of issues is not necessary to do that many retries; especially considering that adcli has a 2min retry delay. 3. reduced the condition handle timeout from 900s to 600s as 10min are enough to include AD admin node bootstrap and 3 adcli retries. 4. Execute the post processing lambda only if the AD admin node was able to setup the directory
…t 5 will be quarantined to limit costs.
gmarciani
force-pushed
the
wip/mgiacomo/3130/wip/mgiacomo/3130/fix-ad-0317-1
branch
from
a088a2e to
42ec878
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Quarantine AD stacks on failure for debugging purposes.
At most 5 will be quarantined to limit costs.
Tests
test_ad_integration succeeds
AD stack is retained on failure (injected artificial failures in Ad stack to trigger the retention)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.