-
Notifications
You must be signed in to change notification settings - Fork 137
Implement read/write timeouts for BIO datagram #2610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2610 +/- ##
==========================================
- Coverage 78.72% 78.71% -0.02%
==========================================
Files 645 645
Lines 110641 111156 +515
Branches 15646 15701 +55
==========================================
+ Hits 87103 87494 +391
- Misses 22840 22970 +130
+ Partials 698 692 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crypto/bio/bio_socket_test.cc
Outdated
// Part 2: Test send timeout | ||
// Triggering a send timeout requires filling the kernel's send buffer, which | ||
// is unreliable. The OS may drop packets or have a very large buffer, | ||
// preventing the send call from blocking. The API's get/set functionality | ||
// is verified in the |SocketDatagramTimeouts| test. | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing part 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its intentionally not there, i wasn't able to simulate forcing a write timeout. I'll get rid of the pt. 2 from the comments. In SocketDatagramTimeouts (the test above this one) we just do a simple get/set check to ensure API works correctly. But we are not able to test the behavior.
Issues:
CryptoAlg-3287
CryptoAlg-3331
Description of changes:
Added
Testing:
Callouts:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.