-
Notifications
You must be signed in to change notification settings - Fork 55
chore(CI): migrate CB CI jobs to GHA #821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
800eb44
chore(CI): migrate CB CI jobs to GHA
josecorella c723507
more
josecorella 070b8a3
more
josecorella 0085170
permissions
josecorella afbb7b1
setuptools
josecorella 8bd317a
Update cfn.yml
josecorella 3f69763
move and rename
josecorella File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
# This workflow runs integration tests with AWS KMS keys | ||
name: integration-tests | ||
|
||
on: | ||
push: | ||
branches: [ master ] | ||
pull_request: | ||
branches: [ master ] | ||
# Run once a day | ||
schedule: | ||
- cron: '0 0 * * *' | ||
|
||
jobs: | ||
test: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12'] | ||
include: | ||
- python-version: '3.8' | ||
toxenv: 'py38-integ-slow' | ||
- python-version: '3.9' | ||
toxenv: 'py39-integ-slow' | ||
- python-version: '3.10' | ||
toxenv: 'py310-integ-slow' | ||
- python-version: '3.11' | ||
toxenv: 'py311-integ-slow' | ||
- python-version: '3.12' | ||
toxenv: 'py312-integ-slow' | ||
permissions: | ||
id-token: write | ||
contents: read | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
|
||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install "tox < 4.0" | ||
|
||
# Python no longer bundles setuptools starting in 3.12 | ||
- name: Install python version specific dependencies | ||
if: matrix.python-version == '3.12' | ||
run: | | ||
pip install setuptools | ||
|
||
- name: Configure AWS Credentials for Tests | ||
uses: aws-actions/configure-aws-credentials@v4 | ||
with: | ||
aws-region: us-west-2 | ||
role-to-assume: arn:aws:iam::370957321024:role/GitHub-CI-DDBEC-Python-Role-us-west-2 | ||
role-session-name: DDBEC-Python-Tests | ||
|
||
- name: Test with tox | ||
env: | ||
TOXENV: ${{ matrix.toxenv }} | ||
AWS_ENCRYPTION_SDK_PYTHON_INTEGRATION_TEST_AWS_KMS_KEY_ID: >- | ||
arn:aws:kms:us-west-2:658956600833:key/b3537ef1-d8dc-4780-9f5a-55776cbb2f7f | ||
AWS_ENCRYPTION_SDK_PYTHON_INTEGRATION_TEST_AWS_KMS_KEY_ID_2: >- | ||
arn:aws:kms:eu-central-1:658956600833:key/75414c93-5285-4b57-99c9-30c1cf0a22c2 | ||
run: tox | ||
|
||
coverage: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: '3.x' | ||
|
||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install "tox < 4.0" | ||
pip install setuptools | ||
|
||
- name: Run coverage | ||
env: | ||
TOXENV: coverage | ||
run: tox |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
AWSTemplateFormatVersion: "2010-09-09" | ||
Description: "DDB Table and IAM Managed Policies/Role for AWS KMS Hierarchical Keyring Testing" | ||
josecorella marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Parameters: | ||
ProjectName: | ||
Type: String | ||
Description: A prefix that will be applied to any names | ||
Default: DDBEC-Python | ||
GitHubRepo: | ||
Type: String | ||
Description: GitHub Repo that invokes CI | ||
Default: aws/aws-dynamodb-encryption-python | ||
|
||
Resources: | ||
GitHubCIRole: | ||
Type: 'AWS::IAM::Role' | ||
Properties: | ||
RoleName: !Sub "GitHub-CI-${ProjectName}-Role-${AWS::Region}" | ||
Description: "Access KMS Resources for CI from GitHub" | ||
ManagedPolicyArns: | ||
- "arn:aws:iam::370957321024:policy/KMS-Public-CMK-EncryptDecrypt-Key-Access" | ||
AssumeRolePolicyDocument: !Sub | | ||
{ | ||
"Version": "2012-10-17", | ||
"Statement": [ | ||
{ | ||
"Effect": "Allow", | ||
"Principal": { "Federated": "arn:aws:iam::${AWS::AccountId}:oidc-provider/token.actions.githubusercontent.com" }, | ||
"Action": "sts:AssumeRoleWithWebIdentity", | ||
"Condition": { | ||
"StringEquals": { | ||
"token.actions.githubusercontent.com:aud": "sts.amazonaws.com" | ||
}, | ||
"StringLike": { | ||
"token.actions.githubusercontent.com:sub": "repo:${GitHubRepo}:*" | ||
} | ||
} | ||
}, | ||
{ | ||
"Effect": "Allow", | ||
"Principal": { | ||
"AWS": "*" | ||
}, | ||
"Action": "sts:AssumeRole", | ||
"Condition": { | ||
"StringEquals": { | ||
"aws:PrincipalArn": [ | ||
"arn:aws:iam::${AWS::AccountId}:role/ToolsDevelopment" | ||
] | ||
} | ||
} | ||
} | ||
] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have CFN for this repo: https://github.com/aws/aws-dynamodb-encryption-python/blob/master/cfn/CB.yml
Should we just add it there? (and/or refactor since it's called
CB.yml
but I don't care about that)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll keep them separate for now since the CB.yml has the infra for the release projects and this poorly named file is only to create a role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Could this file go in the
cfn/
folder though?