Skip to content

chore(python): Plaintext migration examples #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025

Conversation

imabhichow
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Add Plaintext migration examples

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@imabhichow
Copy link
Contributor Author

While Python3.11 throws KeyError when trying to assert an attribute which is not dict. But, Looks like Python3.12 failed with AssertionError instead of KeyError.

@imabhichow imabhichow force-pushed the imabhichow/restruct-legacy branch from c31596f to 6721834 Compare July 8, 2025 22:30
Base automatically changed from imabhichow/restruct-legacy to python-reviewed July 8, 2025 22:36
@imabhichow imabhichow force-pushed the imabhichow/plaintext-migration branch from ccce685 to d640d6c Compare July 8, 2025 22:42
@imabhichow imabhichow changed the base branch from python-reviewed to python-poc July 8, 2025 22:42
@imabhichow imabhichow marked this pull request as ready for review July 8, 2025 22:43
@imabhichow imabhichow requested a review from a team as a code owner July 8, 2025 22:43
@imabhichow imabhichow force-pushed the imabhichow/plaintext-migration branch from d640d6c to 003c0e8 Compare July 8, 2025 23:45
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 nits, otherwise LGTM

@imabhichow imabhichow changed the base branch from python-poc to python-reviewed July 21, 2025 20:07
@imabhichow imabhichow force-pushed the imabhichow/plaintext-migration branch from 78be970 to 2e7f295 Compare July 21, 2025 20:07
@imabhichow imabhichow force-pushed the imabhichow/plaintext-migration branch from 2e7f295 to c51a0ab Compare July 21, 2025 20:10
@imabhichow imabhichow merged commit de4588f into python-reviewed Jul 21, 2025
21 of 62 checks passed
@imabhichow imabhichow deleted the imabhichow/plaintext-migration branch July 21, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants