Support millisecond timestamp precision for bedrock-agentcore #9791
+201
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamRemis
changed the title
aemous
requested changes
Oct 20, 2025
| raise ValueError( | ||
| f"Invalid timestamp precision found while creating serializer: {timestamp_precision}" | ||
| ) | ||
|
|
There was a problem hiding this comment.
nit: can we remove this extra newline to match the formatting in botocore?
| def _timestamp_rfc822(self, value): | ||
| """Return RFC822 timestamp (always second precision - RFC doesn't support sub-second).""" | ||
| if isinstance(value, datetime.datetime): | ||
| value = self._timestamp_unixtimestamp(value) |
There was a problem hiding this comment.
I think this line should be updated to match the botocore PR
|
|
||
| def _timestamp_rfc822(self, value): | ||
| """Return RFC822 timestamp (always second precision - RFC doesn't support sub-second).""" | ||
| if isinstance(value, datetime.datetime): |
There was a problem hiding this comment.
nit: missing one-line comment, to align with the botocore PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port https://github.com/boto/botocore/pull/3568/files