Skip to content

feat: limitless plugin implementation #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025
Merged

Conversation

JuanLeee
Copy link
Collaborator

@JuanLeee JuanLeee commented Jun 28, 2025

Description

Initial Implementation of Limitless Data Support.

https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/limitless.html

Adding only implementation and unit tests for limitless plugin with documentation to follow.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@JuanLeee JuanLeee force-pushed the feat/limitless branch 5 times, most recently from 8be63f9 to e0bdeb6 Compare July 4, 2025 17:42
@JuanLeee JuanLeee changed the title WIP: feat: limitless plugin implementation feat: limitless plugin implementation Jul 4, 2025
@JuanLeee JuanLeee force-pushed the feat/limitless branch 2 times, most recently from eb9c69a to 014bfbb Compare July 4, 2025 17:44
@JuanLeee JuanLeee force-pushed the feat/limitless branch 3 times, most recently from 2675f78 to a34e077 Compare July 8, 2025 10:25
@JuanLeee JuanLeee force-pushed the feat/limitless branch 2 times, most recently from eec4fff to 19f59c7 Compare July 10, 2025 17:18
@JuanLeee JuanLeee force-pushed the feat/limitless branch 5 times, most recently from ff1cee6 to a892ffc Compare July 15, 2025 17:07
logger = Logger(__name__)


class LimitlessConnectionPlugin(Plugin):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Python we decided to drop the "Connection" substring because we thought it was unnecessary and it shortens the class name, can we do the following renames:

  • limitless_connection_plugin.py -> limitless_plugin.py
  • test_limitless_connection_plugin.py -> test_limitless_plugin.py
  • LimitlessConnectionPlugin -> LimitlessPlugin
  • LimitlessConnectionPluginFactory -> LimitlessPluginFactory
  • changing the LimitlessConnectionPlugin.*=[LimitlessConnectionPlugin] ... messages to LimitlessPlugin.*=[LimitlessPlugin] ...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Also changed LimitlessConnectionContext to LimitlessContext

@JuanLeee JuanLeee force-pushed the feat/limitless branch 4 times, most recently from 6ee1b28 to bf12938 Compare July 15, 2025 23:09
@JuanLeee JuanLeee force-pushed the feat/limitless branch 2 times, most recently from cfde75f to 1707084 Compare July 16, 2025 02:15
@karenc-bq karenc-bq merged commit ddbb65f into aws:main Jul 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants