-
Notifications
You must be signed in to change notification settings - Fork 10
feat: limitless plugin implementation #912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8be63f9
to
e0bdeb6
Compare
eb9c69a
to
014bfbb
Compare
aws_advanced_python_wrapper/resources/aws_advanced_python_wrapper_messages.properties
Outdated
Show resolved
Hide resolved
aws_advanced_python_wrapper/resources/aws_advanced_python_wrapper_messages.properties
Outdated
Show resolved
Hide resolved
aws_advanced_python_wrapper/resources/aws_advanced_python_wrapper_messages.properties
Outdated
Show resolved
Hide resolved
aws_advanced_python_wrapper/resources/aws_advanced_python_wrapper_messages.properties
Outdated
Show resolved
Hide resolved
2675f78
to
a34e077
Compare
aws_advanced_python_wrapper/resources/aws_advanced_python_wrapper_messages.properties
Outdated
Show resolved
Hide resolved
aws_advanced_python_wrapper/resources/aws_advanced_python_wrapper_messages.properties
Outdated
Show resolved
Hide resolved
eec4fff
to
19f59c7
Compare
ff1cee6
to
a892ffc
Compare
logger = Logger(__name__) | ||
|
||
|
||
class LimitlessConnectionPlugin(Plugin): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Python we decided to drop the "Connection" substring because we thought it was unnecessary and it shortens the class name, can we do the following renames:
- limitless_connection_plugin.py -> limitless_plugin.py
- test_limitless_connection_plugin.py -> test_limitless_plugin.py
- LimitlessConnectionPlugin -> LimitlessPlugin
- LimitlessConnectionPluginFactory -> LimitlessPluginFactory
- changing the
LimitlessConnectionPlugin.*=[LimitlessConnectionPlugin] ...
messages toLimitlessPlugin.*=[LimitlessPlugin] ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Also changed LimitlessConnectionContext to LimitlessContext
6ee1b28
to
bf12938
Compare
cfde75f
to
1707084
Compare
Description
Initial Implementation of Limitless Data Support.
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/limitless.html
Adding only implementation and unit tests for limitless plugin with documentation to follow.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.