feat: allow custom secret keys for database credentials retrieval #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
reviewed
Mar 13, 2025
| self._mock_client.get_secret_value.assert_called_once() | ||
| self._mock_func.assert_called_once() | ||
| assert self._TEST_USERNAME == self._properties.get("user") | ||
| assert self._TEST_PASSWORD == self._properties.get("password") |
There was a problem hiding this comment.
Suggested change
| assert self._TEST_PASSWORD == self._properties.get("password") | |
| assert self._TEST_PASSWORD == self._properties.get("password") | |
sergiyvamz
approved these changes
Mar 13, 2025
karenc-bq
approved these changes
Mar 13, 2025
|
Thank you for the PR, this is a great suggestion. We will port the changes to other drivers as well. |
|
@karenc-bq @sergiyvamz I have updated the PR, fixing the flake8 issues |
|
@karenc-bq @sergiyvamz the PR is stuck waiting for approvals. |
|
@karenc-bq any updates on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces two new parameters:
secrets_manager_secret_usernamesecrets_manager_secret_passwordThese parameters allow users to specify custom keys for retrieving credentials from a secret JSON.
For example, given the following secret:
{ "custom_username_key": "the database username", "custom_password_key": "the database password" }By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.