test: Add secrets manager test and iam+failover #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophia-bq
approved these changes
Jan 6, 2026
| conn.cursor() | ||
|
|
||
| @enable_on_features([TestEnvironmentFeatures.FAILOVER_SUPPORTED]) | ||
| def test_failover_with_secrets_manager( |
Contributor
There was a problem hiding this comment.
can we move this test to the failover file - esp since the iam test is there instead of in the iam file
Contributor
Author
There was a problem hiding this comment.
I decided to keep this one here since we create the secrets during the test once during the test class and remove it. If we moved it to the failover file then we would have to create a secret there.
I could move the IAM one though to the IAM tests with failover to make it more consistent.
Contributor
There was a problem hiding this comment.
That could work, will require adding the timeout props into that test when moving it over
faviansamatha
force-pushed
the
test/add-integ-tests
branch
from
c2f0afa to
ec7068c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
test: Add secrets manager test and iam+failover
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.