Skip to content

fix: dynamically search for instance classes that have enough availability zones in the region #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

karenc-bq
Copy link
Contributor

@karenc-bq karenc-bq commented May 22, 2025

Summary

Dynamically search for an instance class that has enough availability zones for multi-az integration tests instead of using a hard coded option.

Description

The number of availability zone for each instance class and storage type combination changes due to availability on the service side.
We cannot use a hard coded storage type and instance class.

There isn't a way to determine whether the instance class supports mullti-az db clusters using the SDK, so we need to try the options one by one. For instance, querying the instance class db.m6g.16xlarge using DescribeOrderableDbInstanceOptionsRequest indicates the instance is multi-az capable (multiAZCapable == true), but attempting to create a cluster with engine version 17.2 throws the following exception:

software.amazon.awssdk.services.rds.model.RdsException: The combination of engine version 17.2 and DB instance class db.m6g.16xlarge isn't supported for Multi-AZ DB clusters.

Integration test runs:

Additional Reviewers

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@karenc-bq karenc-bq force-pushed the fix/multiaz-cluster-creation branch from 83dae86 to 6bbe27f Compare May 22, 2025 16:53
Copy link

github-actions bot commented May 22, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@karenc-bq karenc-bq force-pushed the fix/multiaz-cluster-creation branch from 6bbe27f to f1c88e4 Compare May 22, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant