-
Notifications
You must be signed in to change notification settings - Fork 16
feat: put object with instruction file configured #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
8e51328
step 1 - refactoring
kessplas 898c55e
wip - instruction file puts
kessplas fd64f1c
cleanup
kessplas 95b3b5a
Merge branch 'main' of github.com:aws/amazon-s3-encryption-client-jav…
kessplas 3546538
Merge branch 'main' of github.com:aws/amazon-s3-encryption-client-jav…
kessplas ed761d9
more tests in new class
kessplas a34b347
Merge branch 'main' of github.com:aws/amazon-s3-encryption-client-jav…
kessplas d6da2cf
v3 to v2 tests for default client
kessplas 60feafd
Merge branch 'main' of github.com:aws/amazon-s3-encryption-client-jav…
kessplas 288ee65
Fixed nullptr exception in code
9c1c50d
testing whether v2 does or doesn't translate additional parameters fo…
ae6b6b4
Fixed nullptr errors for MultipartUploadObjectPipeline regarding _ins…
c9378cf
Added another convertRequest method to convert CreateMultipartUploadR…
ef353d7
Added test cases for converting MultipartUploadRequests
fbdbe92
Added tests for S3EncryptonClient with Instruction File + Multipart e…
9e25d8f
added .instructionFileConfig for PutEncryptedObjectPipeline builder
7bf259c
cleaned up ContentMetadataEncodingStrategy class
ff5e99c
Added test cases to S3AsyncEncryptionClientTest regarging MPU + instr…
a396a7c
fixed import issues
b1c0898
removed debugging lines
b4b2047
Replaced passing in ARN of my personal testing bucket with the BUCKET…
b9ae158
removed unused import
4f51c42
fixed all changes requested from PR
bf2be6e
Removed HelloWorldProgramExample.java
02f6f48
Fixed the second PR round of reviews
c319d44
testMultipartPutWithInstructionFile() should be working now
0ed41a5
fixed second round of PR
0349dec
removed unused import
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We should add some comments here, i.e. that this is used to set the optional fields for Instruction File puts when the request is a multipart upload, because the instruction file is Put with an ordinary PutObject request.
And likewise for the other
convertRequest
method which is used to set the optional fields on high-level Multipart PutObject requests.