Skip to content

fix: allow CipherSubscriber to determine if the part is last part #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Apr 14, 2025
Merged

fix: allow CipherSubscriber to determine if the part is last part #453

merged 31 commits into from
Apr 14, 2025

Conversation

kessplas
Copy link
Contributor

@kessplas kessplas commented Apr 2, 2025 •
edited
Loading

Issue #, if available:

Description of changes:

Most notably, this lets the CipherSubscriber actually use the isLastPart flag to avoid calling doFinal() before the last part.

Additionally:

  • cleans up some unused code
  • updates AWS SDK deps to latest
  • improves logging for example tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@kessplas kessplas changed the title chore: better logging from MPU examples fix: allow CipherSubscriber to determine if the part is last part Apr 4, 2025
@kessplas kessplas marked this pull request as ready for review April 8, 2025 15:49
@kessplas kessplas requested a review from a team as a code owner April 8, 2025 15:49
ajewellamz
ajewellamz approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@ajewellamz ajewellamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kessplas kessplas merged commit 12355a1 into main Apr 14, 2025
14 checks passed
@kessplas kessplas deleted the mpu-exception branch April 14, 2025 19:41
josecorella pushed a commit that referenced this pull request Apr 16, 2025
@semantic-release-bot
Amazon S3 Encryption Client 3.3.2 Release -- 2025-04-16
4527ce1 
## [3.3.2](v3.3.1...v3.3.2) (2025-04-16)

### Fixes

* add builders to S3EncryptionClientException class ([#450](#450)) ([647c809](647c809))
* allow CipherSubscriber to determine if the part is last part ([#453](#453)) ([12355a1](12355a1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josecorella josecorella josecorella approved these changes

@ajewellamz ajewellamz ajewellamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kessplas @josecorella @ajewellamz