feat: add support for SSE transport in MCP client #1981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [feat]: Add a new semantic_search_client crate that provides vector embedding and
semantic search capabilities for the Amazon Q CLI. This implementation:
- Supports text embedding generation using Candle and ONNX runtimes
- Provides hardware acceleration via Metal on macOS
- Implements efficient vector indexing for semantic search
- Includes file processing utilities for various file types
- Supports persistent storage of semantic contexts
- Includes comprehensive test coverage
This crate will enable memory bank functionality for Amazon Q, allowing
users to create, manage, and search through semantic memory contexts.
🤖 Assisted by [Amazon Q Developer](https://aws.amazon.com/q/developer)
* Update semantic_search_client dependencies in Cargo.toml
* Refactor embedder implementation for Linux platforms to use trait objects
This change modifies the semantic search client to use Box<dyn TextEmbedderTrait>
on Linux platforms instead of directly using CandleTextEmbedder. This provides
more flexibility and consistency with the implementation on macOS and Windows,
allowing for better extensibility and polymorphic behavior across all platforms.
* Update Cargo.lock file
* Remove redundant CandleTextEmbedder import for non-macOS/Windows platforms
* fix(semantic_search): Update conditional compilation flags for embedders
Update conditional compilation flags to match the new embedding model selection logic:
- Replace target_env="musl" conditions with target_os conditions
- Update TextEmbedder trait implementation to use macOS/Windows condition
- Ensure consistent conditions across all files
🤖 Assisted by [Amazon Q Developer](https://aws.amazon.com/q/developer)
---------
Co-authored-by: Kenneth Sanchez V <[email protected]>
Co-authored-by: Kenneth Sanchez V <[email protected]>
* fix Build * fix: Removes flakey test --------- Co-authored-by: Kenneth Sanchez V <[email protected]>
- Tools and prompts are sorted by MCP server alphabetically. Built-in tools always come come first - Within each category (MCP), they are sorted by name alphabetically. - Slightly adjust /tools footer.
… as default (aws#1888) - Removed ONNX embedder implementation and fastembed dependency - Updated conditional compilation to use Candle on all platforms except Linux ARM - Fixed duplicate implementations in error.rs - Updated benchmark tests to remove ONNX references 🤖 Assisted by [Amazon Q Developer](https://aws.amazon.com/q/developer) Co-authored-by: Kenneth Sanchez V <[email protected]>
* chore: update amazon clients * chore: update windows-core in lockfile * chore: exclude semantic search crate
* Revert "chore: exclude semantic search crate" This reverts commit 6fe1e3e. * fix(semantic_search): Fix VectorIndex is_empty implementation The VectorIndex.is_empty() method was incorrectly checking if ef_construction was equal to 100 to determine if the index was empty. This approach was unreliable and caused test failures. This change adds a proper counter to track the number of elements in the index and updates is_empty() to check this counter instead. 🤖 Assisted by [Amazon Q Developer](https://aws.amazon.com/q/developer) --------- Co-authored-by: Kenneth Sanchez V <[email protected]>
* precomputes total number of servers in loading prior to spawning display task * changes display task to use async task instead of spawn blocking * waits on notify instead of display task for initial loading * includes time taken in warning and error * adds slash command to show mcp server load messages * includes mcps that fail to start in /mcp * surfaces command error for mcp servers in non-interactive mode * only surfaces timeout warning in non-interactive mode with one or more server in the client list * adds copy change for /mcp * uses a hash set of server names to keep track of the number of initialized servers * only shows mcp non-interactive msg in non-interactive mode
* chore: add logs for refreshing token * fix: save device registration when launching chat
Co-authored-by: Brandon Kiser <[email protected]>
* remove autocomplete * fix cargo * remove typos config * remove mise and fix deny * fix tests
- Introduced `reqwest-eventsource` and `tokio-stream` dependencies. - Updated `CustomToolConfig` to include optional `url` and `transport` fields. - Enhanced MCP server management to handle both STDIO and SSE transports. - Updated client initialization to support SSE transport with appropriate error handling. - Modified command-line arguments to accommodate new transport options.
|
I'm a Q-Developer Pro user, and the missing feature is blocking Figma MCP integration. Can this be prioritized? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SSE Transport Support for MCP Client
🎯 Overview
This PR introduces Server-Sent Events (SSE) transport support for the Model Context Protocol (MCP) client, expanding beyond the existing STDIO transport to enable HTTP-based MCP server communication.
✨ What's New
Core Features
SseTransportstruct incrates/cli/src/mcp_client/transport/sse.rs--transportflag supportingstdioandsseoptionsTechnical Changes
reqwest-eventsourceandtokio-streamfor SSE handlingmcp addcommand to support transport-specific parametersCustomToolConfigto handle multiple transport typesCustomToolClientenum to support both STDIO and SSE variants🧪 Testing Status
✅ Local Testing Completed
deepwikiMCP server (https://mcp.deepwiki.com/sse)🔍 Recommended Testing Before Merge
We strongly recommend the upstream team conduct comprehensive testing including:
📋 Usage Example
🔧 Implementation Details
Key Files Modified
crates/cli/src/mcp_client/transport/sse.rs- New SSE transport implementationcrates/cli/src/mcp_client/transport/mod.rs- Transport type definitionscrates/cli/src/cli/chat/tools/custom_tool.rs- Client configuration updatescrates/cli/src/cli/chat/mcp.rs- CLI command enhancementsArchitecture
reqwest-eventsourcefor robust SSE handlingPlease treat this as a DRAFT implementation requiring thorough validation.
While functional in local testing, we recommend:
🤝 Feedback Welcome
This implementation aims to expand MCP capabilities while maintaining system stability. We welcome:
Author: @WongLoki
Status: Ready for Review & Testing
Priority: Non-Breaking Enhancement