This repository has been archived by the owner on May 31, 2024. It is now read-only.
feat: allows skipping of specific nextflow files from being cached #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhCloud
force-pushed
the
lcloudy_CacheFilesExcluded
branch
from
2b73987 to
4f948c2
Compare
wleepang
reviewed
Apr 26, 2022
| if dirEntry == nil { | ||
| // There are several use cases when it can happen: | ||
| // 1. provided path doesn't exist | ||
| // 2. file or sub-directory got deleted after being listed by WalkDir | ||
| return fmt.Errorf("file '%s' doesn't exist", currentPath) | ||
| } | ||
|
|
||
| if dirEntry.Name() == ".nextflow" || |
There was a problem hiding this comment.
Rather than having specific hardcoded paths that AGC knows about, can you make it more generic? For example, have an .agc-ignore file in the project or workflow levels, or both, that works like a .gitignore that defines patterns that are ignored during workflow bundling?
|
Greetings! Sorry to say but this is a very old issue that is probably not getting as much attention as it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one. |
github-actions
bot
added
closing-soon
closed-for-staleness
and removed
closing-soon
labels
codon172 adding .agcingore file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of Changes
Running a nextflow workflow generates lots of cache files and logs that may crash before the workflow has started/completed. Allowing nextflow to cache specific large files will make it so that a developer can ensure the workflow is running locally (with small files vs large files that dont allow the run) as expected.
Description of how you validated changes
Units tests have been added and verified.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license