fix: create global entrypoint for tui#1350
Closed
Hweinstock wants to merge 1 commit into
Closed
Conversation
Contributor
Package TarballHow to installgh release download pr-1350-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.14.2.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-cli-automation
approved these changes
May 21, 2026
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Looks good — small, targeted fix that correctly addresses both stated issues:
TelemetryClientAccessor.init('tui', 'tui')is now called beforerenderTUI(), so the bare-agentcoreinvocation gets tagged withmode=tuiinstead of falling back to the lazymode=clidefault.TelemetryClientAccessor.shutdown()is now invoked from thewaitUntilExit().then(...)handler, so the OTLP exporter gets a chance to flush buffered metrics before process exit.
I verified the init signature (init(entrypoint, mode)) — both args being 'tui' is correct. Ink's default Ctrl+C handling unmounts cleanly and resolves waitUntilExit(), so the new shutdown() also runs on the common Ctrl+C-from-TUI exit path. Browser-dev exit action doesn't emit telemetry, so calling shutdown() before launchBrowserDev() is fine for now.
No new issues worth blocking on.
Contributor
Coverage Report
|
Create a unified renderTUI() entrypoint that all TUI-rendering code paths use instead of inline Ink render() calls. This fixes telemetry never being emitted for bare 'agentcore' TUI mode and mislabeling TUI sessions as CLI. - Add renderTUI() with RenderTUIOptions for configurable behavior - Migrate add, deploy, create, remove, invoke commands to use renderTUI() - Add InitialRoute type for type-safe route navigation - Add actionOnBack option to control escape/back behavior - Add enterAltScreen option for inline vs full-screen rendering - Initialize and shutdown TelemetryClientAccessor within renderTUI() Fixes #895
36beb61 to
5e8b462
Compare
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, commands like
agentcore add,agentcore deploy, etc. rendered TUI screens inline via directrender()calls. This made it difficult to distinguish CLI vs TUI code paths, and caused telemetry to be mislabeled asmode="cli"even when running interactive TUI flows. Additionally, bareagentcore(no args) never calledTelemetryClientAccessor.init()orshutdown(), so telemetry was never emitted for the full-screen TUI.This PR creates a unified
renderTUI()entrypoint with aRenderTUIOptionsinterface that all TUI-rendering code paths now use. This ensures:mode="tui"for all TUI sessionsTelemetryClientAccessor.shutdown()is always called on TUI exitInitialRouteChanges
renderTUI()withRenderTUIOptionsfor configurable behavioradd,deploy,create,remove,invokecommands to userenderTUI()InitialRoutetype for type-safe initial route navigationactionOnBackoption to control escape/back behavior (navigate to help vs exit)enterAltScreenoption for inline vs full-screen renderingTelemetryClientAccessorwithinrenderTUI()Related Issue
Fixes #895
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.