Chore: few shot examples #127
Conversation
rstrahan
left a comment
rstrahan
left a comment
There was a problem hiding this comment.
Thanks so much.. I left a couple of comments..
In general it will be much easier to understand and review if you can first create Issues to describe bugs/defects that you encounter, and then create a clean PR per issue to resolve.. This significantly limits the 'blast radius' of each PR, make is easier/safer to review, and we'll get it tested and merged faster.
Is that possible?
| "output_tokens": 0, | ||
| "invocation_count": 0, | ||
| "total_cost": 0.0, | ||
| f"Extraction/{self.config.extraction.model}": { |
There was a problem hiding this comment.
Can you please report a separate Issue to clarify the problem that this is intended to fix? It's not clear to me that we have a bug in metering (looks OK in the UI and metering Athena table), so need clarity here.
| "metadata": {}, | ||
| "source": [ | ||
| "## 1. Install Dependencies\n", | ||
| "## 1. Setup AWS Access" |
There was a problem hiding this comment.
Again I am uncertain what issue this resolves.. and why it would be specific to the notebook? Any notebook should work already based on aws credential provider chain (typically local aws configure profile).. Can you log a separate issue if there is a bug, that this is intended to fix. Tx.
2 participants
Issue #145
Description of changes:
For the configuration
rvl-cdip-package-sample-with-few-shot-examples:For few-shot example notebooks:
For
idp_common/extraction/service.py:By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.