Skip to content

Support for multiple partitions (aws, aws-cn, aws-us-gov) #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support for multiple partitions (aws, aws-cn, aws-us-gov) #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions sagemaker_run_notebook/cloudformation-base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,24 +113,24 @@ Resources:
- events:PutRule
- events:ListTargetsByRule
- events:DisableRule
Resource: 'arn:aws:events:*:*:rule/RunNotebook*'
Resource: {"Fn::Join": [":", ["arn", {"Ref": "AWS::Partition"}, "events:*:*:rule/RunNotebook*'"]] }
- Sid: runnotebooklambda
Effect: Allow
Action:
- lambda:AddPermission
- lambda:InvokeFunction
- lambda:InvokeAsync
- lambda:RemovePermission
Resource: 'arn:aws:lambda:*:*:function:RunNotebook'
Resource: {"Fn::Join": [":", ["arn", {"Ref": "AWS::Partition"}, "lambda:*:*:function:RunNotebook'"]] }
- Sid: s3xfer
Effect: Allow
Action:
- s3:GetObject
- s3:PutObject
Resource:
- 'arn:aws:s3:::*SageMaker*'
- 'arn:aws:s3:::*Sagemaker*'
- 'arn:aws:s3:::*sagemaker*'
- {"Fn::Join": [":", ["arn", {"Ref": "AWS::Partition"}, "s3:::*SageMaker*'"]] }
- {"Fn::Join": [":", ["arn", {"Ref": "AWS::Partition"}, "s3:::*Sagemaker*'"]] }
- {"Fn::Join": [":", ["arn", {"Ref": "AWS::Partition"}, "s3:::*sagemaker*'"]] }
- Sid: s3create
Effect: Allow
Action:
Expand Down Expand Up @@ -178,9 +178,9 @@ Resources:
- s3:ListBucket
- s3:PutObject
Resource:
- 'arn:aws:s3:::*SageMaker*'
- 'arn:aws:s3:::*Sagemaker*'
- 'arn:aws:s3:::*sagemaker*'
- {"Fn::Join": [":", ["arn", {"Ref": "AWS::Partition"}, "s3:::*SageMaker*'"]] }
- {"Fn::Join": [":", ["arn", {"Ref": "AWS::Partition"}, "s3:::*Sagemaker*'"]] }
- {"Fn::Join": [":", ["arn", {"Ref": "AWS::Partition"}, "s3:::*sagemaker*'"]] }
- Sid: vpcattach
Effect: Allow
Action:
Expand Down Expand Up @@ -236,9 +236,9 @@ Resources:
Action:
- s3:GetObject
Resource:
- 'arn:aws:s3:::*SageMaker*'
- 'arn:aws:s3:::*Sagemaker*'
- 'arn:aws:s3:::*sagemaker*'
- {"Fn::Join": [":", ["arn", {"Ref": "AWS::Partition"}, "s3:::*SageMaker*'"]] }
- {"Fn::Join": [":", ["arn", {"Ref": "AWS::Partition"}, "s3:::*Sagemaker*'"]] }
- {"Fn::Join": [":", ["arn", {"Ref": "AWS::Partition"}, "s3:::*sagemaker*'"]] }
LambdaExecutionRole:
Type: 'AWS::IAM::Role'
Properties:
Expand Down Expand Up @@ -269,7 +269,7 @@ Resources:
Action: lambda:InvokeFunction
FunctionName: RunNotebook
Principal: events.amazonaws.com
SourceArn: {"Fn::Join": [":", ["arn:aws:events", {"Ref": "AWS::Region"}, {"Ref": "AWS::AccountId"}, "rule/RunNotebook-*"]]}
SourceArn: {"Fn::Join": [":", ["arn", {"Ref": "AWS::Partition"}, "events", {"Ref": "AWS::Region"}, {"Ref": "AWS::AccountId"}, "rule/RunNotebook-*"]]}
InvokeNotebookLambda:
Type: AWS::Lambda::Function
Properties:
Expand Down