-
Notifications
You must be signed in to change notification settings - Fork 309
Closed network mode (Access from VPC) (閉域モード) #1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
## 閉域環境から GenU を使う場合 | ||
|
||
閉域環境から GenU を利用するには、閉域モードの GenU をデプロイする必要があります。 | ||
閉域モードの GenU のデプロイ方法は [こちら](./CLOSED_NETWORK.md) をご参照ください。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こちらか、CLOSED _NETWORK.mdのどちらかに、デプロイにはDockerが必要である旨の記載をした方が良いかなと思いました!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
key = key.substring(1); | ||
} | ||
|
||
console.log(key); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
デバッグログが残ったまま?になっています。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of Changes
We have enabled closed network mode. The architectural changes are as follows:
Developing this pull request in collaboration with @yuuyeah.
Checklist
npm run cdk:test
and if there are snapshot differences, executenpm run cdk:test:update-snapshot
to update snapshotsRelated Issues