Skip to content

Closed network mode (Access from VPC) (閉域モード) #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Aug 12, 2025
Merged

Conversation

tbrand
Copy link
Contributor

@tbrand tbrand commented Jul 18, 2025

Description of Changes

We have enabled closed network mode. The architectural changes are as follows:

  • Amazon CloudFront is not used, and static web files are served by Application Load Balancer and ECS Fargate.
  • Amazon Cognito is accessed through Amazon API Gateway.
  • Communication from Lambda functions to other services is performed via VPC Endpoints.

Developing this pull request in collaboration with @yuuyeah.

Checklist

  • Modified relevant documentation
  • Verified operation in local environment
  • Executed npm run cdk:test and if there are snapshot differences, execute npm run cdk:test:update-snapshot to update snapshots

Related Issues

@tbrand tbrand added the major Changes equivalent to a major version increment label Jul 18, 2025
@tbrand tbrand changed the base branch from main to v5 July 30, 2025 06:02
@tbrand tbrand changed the title [DNM] Closed network mode (閉域対応) Closed network mode (閉域モード) Aug 1, 2025
@tbrand tbrand marked this pull request as ready for review August 1, 2025 02:47
@tbrand tbrand requested a review from wadabee August 1, 2025 02:49
@tbrand tbrand changed the title Closed network mode (閉域モード) Closed network mode (Access from VPC) (閉域モード) Aug 4, 2025
Comment on lines +2097 to +2100
## 閉域環境から GenU を使う場合

閉域環境から GenU を利用するには、閉域モードの GenU をデプロイする必要があります。
閉域モードの GenU のデプロイ方法は [こちら](./CLOSED_NETWORK.md) をご参照ください。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらか、CLOSED _NETWORK.mdのどちらかに、デプロイにはDockerが必要である旨の記載をした方が良いかなと思いました!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key = key.substring(1);
}

console.log(key);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

デバッグログが残ったまま?になっています。

Copy link
Contributor

@wadabee wadabee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Changes equivalent to a major version increment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants