Skip to content

Improve compliant and noncompliant examples for python/[email protected] #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve compliant and noncompliant examples for python/[email protected] #83

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a03adb
Improve compliant and noncompliant examples for python/pytorch-miss-c…
ankit-amazon May 9, 2023
bfd94ca
Update pytorch_miss_call_to_eval.py
ankit-amazon May 9, 2023
77b491d
Update pytorch_miss_call_to_eval.py
ankit-amazon May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/python/detectors/pytorch_miss_call_to_eval/pytorch_miss_call_to_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,29 @@
# {fact [email protected] defects=1}
def pytorch_miss_call_to_eval_noncompliant(model):
import torch
# Noncompliant: miss call to `eval()` after load.
model.load_state_dict(torch.load("model.pth"))
# Noncompliant: miss call to `eval()` after load.
Copy link

@linghuiluo linghuiluo May 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss call to eval() before evaluating the model.

classes = ["T-shirt/top", "Trouser", "Pullover", "Dress", "Coat",
"Sandal", "Shirt", "Sneaker", "Bag", "Ankle boot"]
x, y = test_data[0][0], test_data[0][1]
with torch.no_grad():
pred = model(x)
predicted, actual = classes[pred[0].argmax(0)], classes[y]
print(f'Predicted: "{predicted}", Actual: "{actual}"')
# {/fact}


# {fact [email protected] defects=0}
def pytorch_miss_call_to_eval_compliant(model):
import torch
model.load_state_dict(torch.load("model.pth"))
classes = ["T-shirt/top", "Trouser", "Pullover", "Dress", "Coat",
"Sandal", "Shirt", "Sneaker", "Bag", "Ankle boot"]
# Compliant: `eval()` is called after load.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eval() is called before evaluating the model.

model.eval()
x, y = test_data[0][0], test_data[0][1]
with torch.no_grad():
pred = model(x)
predicted, actual = classes[pred[0].argmax(0)], classes[y]
print(f'Predicted: "{predicted}", Actual: "{actual}"')
# {/fact}