-
Notifications
You must be signed in to change notification settings - Fork 65
AWS SDK v1.11 SPI Implementation for ADOT Java SDK #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptor after request has been marshalled into HTTP requestion, but before it is sent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Note: this is the second part of the implementation for issue #1091
This PR introduces a new SPI-based implementation for AWS SDK v1.11 instrumentation that:
The SPI instrumentation module is under 'instrumentation/aws-sdk.' There is also a custom 'AdotTracingRequestHandler' for this implementation for ensure correct instrumentation for files that required patching previously. The README.md file in instrumentation/aws-sdk contains a detailed explanation of this implementation.
Testing
To validate the SPI implementation, I utilized the existing AppSignals contract tests. These tests were originally designed to verify AWS SDK v1 instrumentation behaviour. The tests specifically assert that AWS-specific span attributes are correctly captured in the mock collector (i.e. tests git patching logic).
By removing the AWS SDK v1.11 git patching logic from the patching script and running these same contract tests, I could verify that the SPI implementation maintains identical instrumentation behaviour without requiring patches. The successful passing of all AWS SDK v1 contract tests confirms that the SPI implementation correctly generates the expected spans and attributes, effectively replacing the previous patching mechanism.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.