fix: replace deprecated aws_region.name with aws_region.region data sources

[siamkholo2]

This PR removes usage of the deprecated name attribute from the aws_region data source.
It replaces ${data.aws_region.current.name} with ${data.aws_region.current.region} to avoid warnings and maintain compatibility with future Terraform AWS provider versions.

[drewmullen]

Hello - thanks for this PR. Just thinking out loud here... if we accepted this PR, would we also need to bump the required provider version to 6.0+?

[siamkholo2]

Hello - thanks for this PR. Just thinking out loud here... if we accepted this PR, would we also need to bump the required provider version to 6.0+?

Yes please. This warning for the deprecated value comes from the latest version

[drewmullen]

Hmm, i think that would be harder to do.

Ill have to look later to see if region is an attribute of the data source for the version we have currently pinned. if it is - i have no issue merging this: https://github.com/aws-ia/terraform-aws-ipam/blob/main/providers.tf#L6

[siamkholo2]

Hmm, i think that would be harder to do.

Ill have to look later to see if region is an attribute of the data source for the version we have currently pinned. if it is - i have no issue merging this: https://github.com/aws-ia/terraform-aws-ipam/blob/main/providers.tf#L6

Thank you. From what i see, its currently pointing to the latest version hence i was getting this warnings. But please double check

[drewmullen]

hmm.. looks like the region attribute was added with v6, its not in 4.53... updating the providers.tf pin above may not be a big deal. let me think about it - in meetings today:

4.53.0 https://registry.terraform.io/providers/hashicorp/aws/4.53.0/docs/data-sources/region

thanks again for opening this :) ill get back to you shortly

[drewmullen]

ok so i think we're fine to merge this and then just do a minor version bump. If anyone wants to stay on the old version they can version pin. Before we merge can you please:

1. bump the required providers to 6.0: https://github.com/aws-ia/terraform-aws-ipam/blob/main/providers.tf#L6
2. run terraform-docs (or the pre-commit)

[lastradanet]

@siamkholo2 , any updates on #73 (comment)?

[siamkholo2]

@siamkholo2 , any updates on #73 (comment)?

I have updated the required version to 6.0 as suggested also ran terraform-doc

[drewmullen]

@andrew-glenn if you can please do a minor bump