Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamCity Documentation #556

Merged
merged 1 commit into from
Apr 7, 2025
Merged

TeamCity Documentation #556

merged 1 commit into from
Apr 7, 2025

Conversation

awsbilal
Copy link
Contributor

@awsbilal awsbilal commented Apr 3, 2025

Summary

closes #557

Changes

Please provide a summary of what's being changed

Added content to blank Complete.md file in docs/teamcity/examples which contains information on what the module provisions, expected input variables, and a summary of the expected deployment.

User experience

Please share what the user experience looks like before and after this change

They see documentation instead of an empty page.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
Is this a breaking change?

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.

@awsbilal awsbilal force-pushed the awsbilal/teamcity_docs branch from 6ecf77f to 336b47b Compare April 3, 2025 20:37
@awsbilal awsbilal changed the title Docs initialized docs folders TeamCity Documentation Apr 3, 2025
@awsbilal awsbilal marked this pull request as ready for review April 3, 2025 20:42
@awsbilal awsbilal requested a review from a team as a code owner April 3, 2025 20:42
@awsbilal awsbilal requested a review from jedobi April 3, 2025 20:42
@awsbilal awsbilal requested review from cwwalb and henrykie and removed request for jedobi April 3, 2025 20:46
@awsbilal awsbilal force-pushed the awsbilal/teamcity_docs branch from 336b47b to d293832 Compare April 3, 2025 20:54
cwwalb
cwwalb previously approved these changes Apr 4, 2025
Copy link
Contributor

@cwwalb cwwalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

jorisdon
jorisdon previously approved these changes Apr 7, 2025
@awsbilal awsbilal dismissed stale reviews from jorisdon and cwwalb via 369e5ac April 7, 2025 16:25
@awsbilal awsbilal force-pushed the awsbilal/teamcity_docs branch from 369e5ac to 5e40130 Compare April 7, 2025 16:57
@henrykie henrykie requested a review from cwwalb April 7, 2025 16:57
Copy link
Contributor

@henrykie henrykie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@cwwalb cwwalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@henrykie henrykie merged commit 6493f0c into main Apr 7, 2025
3 checks passed
@awsbilal awsbilal deleted the awsbilal/teamcity_docs branch April 10, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Docs: TeamCity docs
4 participants