Add iscsci support #458

adizalmanovich1 · 2025-01-30T08:34:01Z

No description provided.

modules/perforce/fsxn_resources/resources.tf

modules/perforce/fsxn_resources/link.tf

h0lmstr0m · 2025-02-06T19:01:02Z

modules/perforce/examples/fsxn/main.tf

+  storage_capacity    = 1024
+  subnet_ids          = [var.instance_subnet_id]
+  preferred_subnet_id = var.instance_subnet_id
+  deployment_type     = "SINGLE_AZ_1"


Question, there is discussion right now with Riot and Epic that may result in a recommendation of Multi-AZ FSxN and Primary/Secondary Helix Core servers as the primary recommendation for running Perforce primary repo in production on AWS on FSxN. Should that be defined here, or is that better for "guidance" in the documentation?

We will do this. This example showcases a single Helix Core server deployment. We do not currently have support to configure Helix Core servers as Edge / Replica / Standby, although @GrzesiekO is working on that currently.

henrykie

Couple minor things we need to adjust:

Rebase main to pull in changes to packer base AMI version
Potentially update example to create VPC and handle DNS to follow existing patterns

I can add these changes.

henrykie · 2025-02-04T15:37:39Z

assets/packer/perforce/helix-core/perforce_arm64.pkr.hcl

@@ -50,7 +50,7 @@ source "amazon-ebs" "al2023" {

  source_ami_filter {
    filters = {
-      name                = "al2023-ami-2023.5.*"


We merged a fix for this. We should rebase main onto this branch before merging.

ok, merged it to the fork

henrykie · 2025-02-04T15:39:06Z

modules/perforce/examples/fsxn/variables.tf

This is fine - I will note that our other examples / samples are designed to be as easy as possible to deploy, so we minimize variables. That means the examples / samples will also provision supporting infrastructure like VPCs, DNS resources. Here we are expecting the end user to provide those. If you'd like @adizalmanovich1 I can add changes that bring the example more in line with the expected format.

henrykie · 2025-02-06T19:04:15Z

modules/perforce/examples/fsxn/main.tf

+  storage_capacity    = 1024
+  subnet_ids          = [var.instance_subnet_id]
+  preferred_subnet_id = var.instance_subnet_id
+  deployment_type     = "SINGLE_AZ_1"


We will do this. This example showcases a single Helix Core server deployment. We do not currently have support to configure Helix Core servers as Edge / Replica / Standby, although @GrzesiekO is working on that currently.

h0lmstr0m · 2025-02-06T19:21:30Z

modules/perforce/examples/fsxn/main.tf

I may just be missing it, but is autogrow for the Helix Core luns configured as part of the TF here? Same for the FS itself? I believe customers will have an assumption that the volumes will be elastic like EBS and are generally not knowledgable on iSCSI.

Bumps [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials) from 4.0.2 to 4.0.3. - [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases) - [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md) - [Commits](aws-actions/configure-aws-credentials@v4.0.2...v4.0.3) --- updated-dependencies: - dependency-name: aws-actions/configure-aws-credentials dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

…1 update Bumps the awscc-provider group with 1 update in the /modules/perforce/helix-authentication-service directory: [hashicorp/awscc](https://github.com/hashicorp/terraform-provider-awscc). Bumps the awscc-provider group with 1 update in the /modules/perforce/helix-core directory: [hashicorp/awscc](https://github.com/hashicorp/terraform-provider-awscc). Updates `hashicorp/awscc` from 1.26.0 to 1.27.0 - [Release notes](https://github.com/hashicorp/terraform-provider-awscc/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-awscc/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-awscc@v1.26.0...v1.27.0) Updates `hashicorp/awscc` from 1.26.0 to 1.27.0 - [Release notes](https://github.com/hashicorp/terraform-provider-awscc/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-awscc/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-awscc@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: hashicorp/awscc dependency-type: direct:production update-type: version-update:semver-minor dependency-group: awscc-provider - dependency-name: hashicorp/awscc dependency-type: direct:production update-type: version-update:semver-minor dependency-group: awscc-provider ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps squidfunk/mkdocs-material from 9.5.50 to 9.6.1. --- updated-dependencies: - dependency-name: squidfunk/mkdocs-material dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…update Bumps the aws-provider group with 1 update in the /modules/jenkins directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws). Bumps the aws-provider group with 1 update in the /modules/perforce/helix-authentication-service directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws). Bumps the aws-provider group with 1 update in the /modules/perforce/helix-core directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws). Bumps the aws-provider group with 1 update in the /modules/perforce/helix-swarm directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws). Bumps the aws-provider group with 1 update in the /samples/simple-build-pipeline directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws). Updates `hashicorp/aws` from 5.84.0 to 5.85.0 - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.84.0...v5.85.0) Updates `hashicorp/aws` from 5.84.0 to 5.85.0 - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.84.0...v5.85.0) Updates `hashicorp/aws` from 5.84.0 to 5.85.0 - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.84.0...v5.85.0) Updates `hashicorp/aws` from 5.84.0 to 5.85.0 - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.84.0...v5.85.0) Updates `hashicorp/aws` from 5.84.0 to 5.85.0 - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.84.0...v5.85.0) --- updated-dependencies: - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-provider - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-provider - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-provider - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-provider - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-provider ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.50 to 9.6.2. - [Release notes](https://github.com/squidfunk/mkdocs-material/releases) - [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG) - [Commits](squidfunk/mkdocs-material@9.5.50...9.6.2) --- updated-dependencies: - dependency-name: mkdocs-material dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: Henry Kiem <[email protected]>

Bumps squidfunk/mkdocs-material from 9.6.1 to 9.6.2. --- updated-dependencies: - dependency-name: squidfunk/mkdocs-material dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.6.2 to 9.6.3. - [Release notes](https://github.com/squidfunk/mkdocs-material/releases) - [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG) - [Commits](squidfunk/mkdocs-material@9.6.2...9.6.3) --- updated-dependencies: - dependency-name: mkdocs-material dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

…1 update Bumps the awscc-provider group with 1 update in the /modules/perforce/helix-authentication-service directory: [hashicorp/awscc](https://github.com/hashicorp/terraform-provider-awscc). Bumps the awscc-provider group with 1 update in the /modules/perforce/helix-core directory: [hashicorp/awscc](https://github.com/hashicorp/terraform-provider-awscc). Updates `hashicorp/awscc` from 1.27.0 to 1.28.0 - [Release notes](https://github.com/hashicorp/terraform-provider-awscc/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-awscc/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-awscc@v1.27.0...v1.28.0) Updates `hashicorp/awscc` from 1.27.0 to 1.28.0 - [Release notes](https://github.com/hashicorp/terraform-provider-awscc/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-awscc/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-awscc@v1.27.0...v1.28.0) --- updated-dependencies: - dependency-name: hashicorp/awscc dependency-type: direct:production update-type: version-update:semver-minor dependency-group: awscc-provider - dependency-name: hashicorp/awscc dependency-type: direct:production update-type: version-update:semver-minor dependency-group: awscc-provider ... Signed-off-by: dependabot[bot] <[email protected]>

…update Bumps the aws-provider group with 1 update in the /modules/jenkins directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws). Bumps the aws-provider group with 1 update in the /modules/perforce/helix-authentication-service directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws). Bumps the aws-provider group with 1 update in the /modules/perforce/helix-core directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws). Bumps the aws-provider group with 1 update in the /modules/perforce/helix-swarm directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws). Bumps the aws-provider group with 1 update in the /samples/simple-build-pipeline directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws). Updates `hashicorp/aws` from 5.85.0 to 5.86.1 - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.85.0...v5.86.1) Updates `hashicorp/aws` from 5.85.0 to 5.86.1 - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.85.0...v5.86.1) Updates `hashicorp/aws` from 5.85.0 to 5.86.1 - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.85.0...v5.86.1) Updates `hashicorp/aws` from 5.85.0 to 5.86.1 - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.85.0...v5.86.1) Updates `hashicorp/aws` from 5.85.0 to 5.86.1 - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.85.0...v5.86.1) --- updated-dependencies: - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-provider - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-provider - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-provider - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-provider - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-provider ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials) from 4.0.3 to 4.1.0. - [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases) - [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md) - [Commits](aws-actions/configure-aws-credentials@v4.0.3...v4.1.0) --- updated-dependencies: - dependency-name: aws-actions/configure-aws-credentials dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps squidfunk/mkdocs-material from 9.6.2 to 9.6.4. --- updated-dependencies: - dependency-name: squidfunk/mkdocs-material dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

…update Bumps the aws-provider group with 1 update in the /modules/jenkins directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws). Bumps the aws-provider group with 1 update in the /modules/perforce/helix-authentication-service directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws). Bumps the aws-provider group with 1 update in the /modules/perforce/helix-core directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws). Bumps the aws-provider group with 1 update in the /modules/perforce/helix-swarm directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws). Bumps the aws-provider group with 1 update in the /samples/simple-build-pipeline directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws). Updates `hashicorp/aws` from 5.86.1 to 5.87.0 - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.86.1...v5.87.0) Updates `hashicorp/aws` from 5.86.1 to 5.87.0 - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.86.1...v5.87.0) Updates `hashicorp/aws` from 5.86.1 to 5.87.0 - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.86.1...v5.87.0) Updates `hashicorp/aws` from 5.86.1 to 5.87.0 - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.86.1...v5.87.0) Updates `hashicorp/aws` from 5.86.1 to 5.87.0 - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.86.1...v5.87.0) --- updated-dependencies: - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-provider - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-provider - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-provider - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-provider - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-provider ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.6.3 to 9.6.4. - [Release notes](https://github.com/squidfunk/mkdocs-material/releases) - [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG) - [Commits](squidfunk/mkdocs-material@9.6.3...9.6.4) --- updated-dependencies: - dependency-name: mkdocs-material dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

LirazRom10 · 2025-02-16T15:19:48Z

@henrykie i have added the missing items to the sample
now it is like the regular complete
in addition also rebased so the ami changes there

henrykie · 2025-03-13T05:48:57Z

Still working on refactoring. Should have updates soon. Sorry for the delay!

adizalmanovich1 added 5 commits January 16, 2025 14:28

add FSxN support

be5f564

Merge branch 'aws-games:main' into main

6a0b79d

add iscsi support

0d3bf00

add iscsi support

21e68a9

add iscsi support

b50c521

adizalmanovich1 requested a review from a team as a code owner January 30, 2025 08:34

adizalmanovich1 requested a review from jorisdon January 30, 2025 08:34

henrykie requested a review from GrzesiekO January 30, 2025 16:29

gabebatista reviewed Jan 31, 2025

View reviewed changes

modules/perforce/fsxn_resources/resources.tf Show resolved Hide resolved

gabebatista reviewed Jan 31, 2025

View reviewed changes

modules/perforce/fsxn_resources/link.tf Outdated Show resolved Hide resolved

henrykie mentioned this pull request Feb 3, 2025

add FSxN support #445

Closed

3 tasks

h0lmstr0m reviewed Feb 6, 2025

View reviewed changes

henrykie requested changes Feb 6, 2025

View reviewed changes

h0lmstr0m reviewed Feb 6, 2025

View reviewed changes

dependabot bot and others added 16 commits February 16, 2025 10:18

fix: AMI version bump for Helix Core, region variable made optional

ae3d652

Fixed S3 object deletion bug, and minor README update.

1d70638

Feature: Unreal Cloud DDC Module and Examples (aws-games#341)

4c7568c

Co-authored-by: Henry Kiem <[email protected]>

LirazRom10 added 3 commits February 16, 2025 10:23

Merge remote-tracking branch 'origin/main' into add_iscsci_support

2b36e9c

Merge branch 'aws-games:main' into add_iscsci_support

9b51fea

add resources to sample

d2a4696

henrykie self-requested a review March 5, 2025 16:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add iscsci support #458

Add iscsci support #458

adizalmanovich1 commented Jan 30, 2025

h0lmstr0m Feb 6, 2025 •

edited

Loading

henrykie Feb 6, 2025

henrykie left a comment

henrykie Feb 4, 2025

LirazRom10 Feb 16, 2025

henrykie Feb 4, 2025

LirazRom10 Feb 16, 2025

henrykie Feb 6, 2025

h0lmstr0m Feb 6, 2025 •

edited

Loading

LirazRom10 commented Feb 16, 2025

henrykie commented Mar 13, 2025

Add iscsci support #458

Are you sure you want to change the base?

Add iscsci support #458

Conversation

adizalmanovich1 commented Jan 30, 2025

h0lmstr0m Feb 6, 2025 • edited Loading

Choose a reason for hiding this comment

henrykie Feb 6, 2025

Choose a reason for hiding this comment

henrykie left a comment

Choose a reason for hiding this comment

henrykie Feb 4, 2025

Choose a reason for hiding this comment

LirazRom10 Feb 16, 2025

Choose a reason for hiding this comment

henrykie Feb 4, 2025

Choose a reason for hiding this comment

LirazRom10 Feb 16, 2025

Choose a reason for hiding this comment

henrykie Feb 6, 2025

Choose a reason for hiding this comment

h0lmstr0m Feb 6, 2025 • edited Loading

Choose a reason for hiding this comment

LirazRom10 commented Feb 16, 2025

henrykie commented Mar 13, 2025

h0lmstr0m Feb 6, 2025 •

edited

Loading

h0lmstr0m Feb 6, 2025 •

edited

Loading