Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement resource ReceiptRule #8

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cPu1
Copy link
Contributor

@cPu1 cPu1 commented Nov 15, 2024

Issue #, if available:

Description of changes:
This is based off the cPu1:resource/receipt-rule-set branch and must be reviewed after merging #9.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested a review from a-hilaly November 15, 2024 11:13
Copy link

ack-prow bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cPu1
Once this PR has been reviewed and has the lgtm label, please assign michaelhtm for approval by writing /assign @michaelhtm in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested a review from michaelhtm November 15, 2024 11:13
@cPu1 cPu1 force-pushed the resource/receipt-rule branch from 2c9ce47 to bbd4311 Compare November 15, 2024 11:16
@cPu1 cPu1 force-pushed the resource/receipt-rule branch from bbd4311 to 26665ec Compare November 15, 2024 11:38
Copy link

ack-prow bot commented Nov 15, 2024

@cPu1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ses-verify-attribution 26665ec link false /test ses-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly
Copy link
Member

pending #7 changes
/hold

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants