Go V2 Controller #81
Go V2 Controller #81
Conversation
|
@rushmash91: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| advancedOptions = make(map[string]*string) | ||
| advancedOptions[allowedAdvancedOption] = desired.ko.Spec.AdvancedOptions[allowedAdvancedOption] | ||
| } | ||
| resp, err := rm.sdkapi.UpgradeDomainWithContext(ctx, &svcsdk.UpgradeDomainInput{ | ||
| AdvancedOptions: advancedOptions, | ||
| advancedOptions_string := make(map[string]string) | ||
| for k, v := range advancedOptions { | ||
| advancedOptions_string[k] = *v | ||
| } |
There was a problem hiding this comment.
nit: we can use advancedOptions and convert with something like aws.ToStringSlice
| DedicatedMasterType: aws.String(string(resp.DomainConfig.ClusterConfig.Options.DedicatedMasterType)), | ||
| InstanceCount: aws.Int64(int64(*resp.DomainConfig.ClusterConfig.Options.InstanceCount)), | ||
| InstanceType: aws.String(string(resp.DomainConfig.ClusterConfig.Options.InstanceType)), | ||
| WarmCount: aws.Int64(int64(*resp.DomainConfig.ClusterConfig.Options.WarmCount)), |
There was a problem hiding this comment.
i'm afraid these might panic if nil..
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.