Fix RBAC Role and Service Account names in build-controller-release.sh script.
#279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
requested changes
Jan 28, 2022
script. 6da05cd introduced a small bug in the RBAC and Service Account names generation. This patch reverts that specific change.
a-hilaly
force-pushed
the
build-controller-release
branch
from
f2ac3c6 to
f58216d
Compare
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
6da05cd introduced a small bug in the RBAC and Service Account names
generation. This patch reverts that specific change.
SERVICEvariable name is declared in line 116, henceK8S_RBAC_ROLE_NAMEandACK_GENERATE_SERVICE_ACCOUNT_NAMEshould be declared after.By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.