Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate controller using aws-sdk-go-v2 #131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Generate controller using aws-sdk-go-v2 #131

wants to merge 1 commit into from
+3,177 −729

Conversation

TiberiuGC
Copy link
Member

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm January 31, 2025 09:41
@ack-prow ACK Prow
Copy link

ack-prow bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TiberiuGC
Once this PR has been reviewed and has the lgtm label, please assign michaelhtm for approval by writing /assign @michaelhtm in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TiberiuGC TiberiuGC force-pushed the improvement/aws-sdk-go-v2 branch from 30c03b2 to 307993a Compare February 1, 2025 11:30
@ack-prow ACK Prow
Copy link

ack-prow bot commented Feb 1, 2025

@TiberiuGC: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
applicationautoscaling-verify-attribution 307993a link false /test applicationautoscaling-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

michaelhtm
michaelhtm reviewed Feb 3, 2025
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @TiberiuGC 🚀,
left few comments addressing new field additions

config/crd/bases/applicationautoscaling.services.k8s.aws_scalabletargets.yaml
@@ -238,6 +281,22 @@ spec:
scheduledScalingSuspended:
type: boolean
type: object
tags:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we ignore this field for now? we can add it in a future PR, just in case we need custom code

config/crd/bases/applicationautoscaling.services.k8s.aws_scalingpolicies.yaml
@@ -65,13 +71,237 @@ spec:
and Step scaling policies (https://docs.aws.amazon.com/autoscaling/application/userguide/application-auto-scaling-step-scaling-policies.html)
in the Application Auto Scaling User Guide.
type: string
predictiveScalingPolicyConfiguration:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelhtm michaelhtm michaelhtm left review comments

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TiberiuGC @michaelhtm