Update AutoScalingRollingUpdates.yaml #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix "LaunchConfig deprecated" problem
|
solve #480 |
ericzbeard
reviewed
Mar 31, 2025
| @@ -191,6 +191,7 @@ Mappings: | |||
| AWSRegionArch2AMI: | |||
| us-east-1: | |||
| PV64: ami-2a69aa47 | |||
| #HVM64: ami-02f624c08a83ca16f #Amazon Linux 2, a newer version AMI, able to login in Linux console with EC2 "Connect" | |||
There was a problem hiding this comment.
Why do we need this commented out line?
There was a problem hiding this comment.
This line is only for a newer Amazon Linux 2 AMI, which is convenient to debug with Linux console.
There is no direct relationship with the "launch configuration deprecated problem".
This line can be deleted. And sorry for that.
There was a problem hiding this comment.
@ericzbeard do I need to recommit the code? And looking forward your reply~~ thank you
There was a problem hiding this comment.
@ericzbeard I have deleted the commented out line. thank you ~~
fix "LaunchConfig deprecated" problem
ericzbeard
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix "LaunchConfig deprecated" problem
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.