Skip to content

fix incorrect recover #5295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix incorrect recover #5295

wants to merge 1 commit into from
+129 −16

Conversation

@dourgulf
Copy link

Description of changes:

  1. add an stop method to UploadTask and MultiPartUploadTask, this function will cancel current upload but not remove record from DB, and could be recover later.
  2. fix incorrect recover logic:
  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

fix incorrect recover
d7ba6f8 
1. fix fix incorrect recover of multi-part upload
2. add stop method to task, it can pause current upload and recover later
@dourgulf dourgulf requested review from a team and awsmobilesdk as code owners April 19, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awsmobilesdk awsmobilesdk Awaiting requested review from awsmobilesdk awsmobilesdk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dourgulf